GuiDBTuples credit mining removal #2398

ardhipoetra · 2016-07-02T04:28:00Z

As fix for Issue #2356.

This will remove Main package dependencies on credit mining. It might be slow when downloading the credit source, but it works. How can I download the torrent via DHT/Peers?

Btw, made PR into next because this is a bugfix for experimental feature (credit mining)

ardhipoetra · 2016-07-02T04:42:45Z

Mind to review, @devos50, @lfdversluis?

ardhipoetra · 2016-07-02T05:25:21Z

retest this please

EDIT: https://jenkins.tribler.org/job/GH_Tribler_PR_tests_linux/2368/testReport/junit/Tribler.Test.Core.test_session/TestSessionAsServer/test_add_torrent_def_to_channel/

lfdversluis · 2016-07-03T20:11:42Z

Tribler/Policies/BoostingSource.py

+            self.loaded_torrent[infohash] = tdef
+
+            if callback is not None:
+                callback(tdef)


you may want to use a deferred here

ardhipoetra · 2016-07-04T05:10:12Z

@lfdversluis pushed commits on your feedback. What do you think?

ardhipoetra · 2016-07-13T09:03:31Z

retest this please

ardhipoetra · 2016-07-13T10:03:24Z

I'm pretty finished with this one. Any thoughts, @devos50, @whirm?

ardhipoetra · 2016-07-14T08:18:42Z

retest this please

ardhipoetra · 2016-07-14T14:59:22Z

retest this please

error in mac, TestDownloadsEndpoint.test_get_downloads

devos50 · 2016-07-14T20:44:11Z

Tribler/Policies/BoostingSource.py

-                self.torrents[infohash]['num_seeders'] = torrent.swarminfo[0] or 0
-                self.torrents[infohash]['num_leechers'] = torrent.swarminfo[1] or 0
+                self.torrents[infohash]['name'] = torrent.get_name()
+                self.torrents[infohash]['metainfo'] = torrent


Does the torrent object really represent the metainfo of the torrent?

I think yes, torrent object is a TorrentDef type

devos50 · 2016-07-14T20:52:15Z

@ardhipoetra I gave my comments. Overall, it looks good and I'm glad you are able to remove much code in this PR :)

ardhipoetra · 2016-07-15T06:38:52Z

@devos50 processed! :D

ardhipoetra · 2016-07-15T07:00:54Z

retest this please

credit mining error in Mac

ardhipoetra · 2016-07-17T10:01:50Z

retest this please

devos50 · 2016-07-18T14:48:34Z

@ardhipoetra looks fine, let's put it on ready so @whirm can take a look.

ardhipoetra · 2016-07-18T15:50:42Z

@devos50 Thanks! :D

whirm · 2016-07-19T10:35:42Z

This check_and_register() function looks a bit fishy... why do you need this?

Also the _check_tor looping call should be canceled instead of having the triple check on BoostingSource.py:293

devos50

@ardhipoetra looks good 👍 . Besides my looping call comment, I have one additional question: can you squash the first commit (where you remove the dependency on GUIDBTuple) and the commit(s) where you refactor the _load_torrent method to use deferreds?

After that, please squash and I will merge if it's ok.

devos50 · 2016-10-18T07:38:54Z

Tribler/Test/Core/CreditMining/test_creditmining_sys.py

+            """
+            check if a torrent has been loaded
+            """
+            if defer_param is None:


Please use the looping call mechanism here that I recently adopted in your tests (see the other tests in this file to see how I did that).

Closes Tribler#2356 Squashed : - Refactor to use deferred

ardhipoetra · 2016-10-18T11:01:25Z

retest this please

looks good

ardhipoetra · 2016-10-18T12:11:47Z

retest this please

last run okay

ardhipoetra · 2016-10-18T12:24:17Z

retest this please

last run : error in linux, get_settings Rest Api

synctext · 2016-10-18T12:58:58Z

retest this please

ardhipoetra · 2016-10-18T13:14:37Z

looks stable enough for me. What do you think @devos50?

synctext · 2016-10-18T13:39:56Z

retest this please

synctext · 2016-10-18T14:35:51Z

retest this please

synctext · 2016-10-19T06:55:40Z

retest this please

synctext · 2016-10-19T07:18:21Z

retest this please

synctext · 2016-10-19T08:07:28Z

retest this please

synctext · 2016-10-19T08:37:07Z

retest this please

devos50

Please remove the indicated commented-out code line, squash your last two commits (where you create the test and refactor it with the looping call) and I will merge 👍

devos50 · 2016-10-19T11:54:49Z

Tribler/Policies/BoostingSource.py

        def add_to_loaded(infohash_str):
            """
            function to add loaded infohash to memory
            """
            self.loaded_torrent[unhexlify(infohash_str)].callback(
                TorrentDef.load_from_memory(self.session.get_collected_torrent(unhexlify(infohash_str))))
-            self.loaded_torrent[unhexlify(infohash_str)] = None
+
+            # self.loaded_torrent[unhexlify(infohash_str)] = None


Please remove this commented-out code.

Squashed commits with : - Use looping call in checking loaded torrent

ardhipoetra · 2016-10-19T13:57:11Z

@devos50 ready!

ardhipoetra changed the title ~~GuiDBTuples credit mining removal~~ WIP: GuiDBTuples credit mining removal Jul 2, 2016

ardhipoetra force-pushed the guituples_cm_removal branch from 1b78780 to a30122d Compare July 2, 2016 04:45

lfdversluis reviewed Jul 3, 2016
View reviewed changes

ardhipoetra force-pushed the guituples_cm_removal branch from 6694c02 to 5f5db94 Compare July 4, 2016 05:11

ardhipoetra mentioned this pull request Jul 14, 2016

New Tribler PyQt GUI #2153

Merged

122 tasks

devos50 reviewed Jul 14, 2016
View reviewed changes

ardhipoetra changed the title ~~WIP: GuiDBTuples credit mining removal~~ READY: GuiDBTuples credit mining removal Jul 18, 2016

devos50 suggested changes Oct 18, 2016

View reviewed changes

ardhipoetra added 2 commits October 18, 2016 11:47

Remove GUIDBTuples from Credit mining

7a1970e

Closes Tribler#2356 Squashed : - Refactor to use deferred

Refactor GUI to cope with GUIDBTuples removal

1e20d37

ardhipoetra force-pushed the guituples_cm_removal branch 7 times, most recently from 1e2d71c to 2094ebd Compare October 18, 2016 10:34

devos50 suggested changes Oct 19, 2016

View reviewed changes

ardhipoetra added 2 commits October 19, 2016 14:10

Removed session and task check

7c7c99b

Add test for native loading

5b6a6f0

Squashed commits with : - Use looping call in checking loaded torrent

ardhipoetra force-pushed the guituples_cm_removal branch from 2094ebd to 5b6a6f0 Compare October 19, 2016 12:10

devos50 approved these changes Oct 19, 2016

View reviewed changes

devos50 merged commit ec94554 into Tribler:next Oct 19, 2016

devos50 changed the title ~~WIP: GuiDBTuples credit mining removal~~ GuiDBTuples credit mining removal Oct 19, 2016

ardhipoetra mentioned this pull request Oct 19, 2016

Credit mining (tests) are dependent on GUI code (GUIDBTuples) #2356

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GuiDBTuples credit mining removal #2398

GuiDBTuples credit mining removal #2398

ardhipoetra commented Jul 2, 2016 •

edited

Loading

ardhipoetra commented Jul 2, 2016

ardhipoetra commented Jul 2, 2016 •

edited

Loading

lfdversluis Jul 3, 2016

ardhipoetra commented Jul 4, 2016

ardhipoetra commented Jul 13, 2016

ardhipoetra commented Jul 13, 2016

ardhipoetra commented Jul 14, 2016

ardhipoetra commented Jul 14, 2016

devos50 Jul 14, 2016

ardhipoetra Jul 15, 2016

devos50 commented Jul 14, 2016

ardhipoetra commented Jul 15, 2016

ardhipoetra commented Jul 15, 2016 •

edited

Loading

ardhipoetra commented Jul 17, 2016

devos50 commented Jul 18, 2016

ardhipoetra commented Jul 18, 2016

whirm commented Jul 19, 2016

devos50 left a comment

devos50 Oct 18, 2016

ardhipoetra commented Oct 18, 2016

ardhipoetra commented Oct 18, 2016

ardhipoetra commented Oct 18, 2016 •

edited

Loading

synctext commented Oct 18, 2016

ardhipoetra commented Oct 18, 2016

synctext commented Oct 18, 2016

synctext commented Oct 18, 2016

synctext commented Oct 19, 2016

synctext commented Oct 19, 2016

synctext commented Oct 19, 2016

synctext commented Oct 19, 2016

devos50 left a comment

devos50 Oct 19, 2016

ardhipoetra commented Oct 19, 2016

GuiDBTuples credit mining removal #2398

GuiDBTuples credit mining removal #2398

Conversation

ardhipoetra commented Jul 2, 2016 • edited Loading

ardhipoetra commented Jul 2, 2016

ardhipoetra commented Jul 2, 2016 • edited Loading

lfdversluis Jul 3, 2016

Choose a reason for hiding this comment

ardhipoetra commented Jul 4, 2016

ardhipoetra commented Jul 13, 2016

ardhipoetra commented Jul 13, 2016

ardhipoetra commented Jul 14, 2016

ardhipoetra commented Jul 14, 2016

devos50 Jul 14, 2016

Choose a reason for hiding this comment

ardhipoetra Jul 15, 2016

Choose a reason for hiding this comment

devos50 commented Jul 14, 2016

ardhipoetra commented Jul 15, 2016

ardhipoetra commented Jul 15, 2016 • edited Loading

ardhipoetra commented Jul 17, 2016

devos50 commented Jul 18, 2016

ardhipoetra commented Jul 18, 2016

whirm commented Jul 19, 2016

devos50 left a comment

Choose a reason for hiding this comment

devos50 Oct 18, 2016

Choose a reason for hiding this comment

ardhipoetra commented Oct 18, 2016

ardhipoetra commented Oct 18, 2016

ardhipoetra commented Oct 18, 2016 • edited Loading

synctext commented Oct 18, 2016

ardhipoetra commented Oct 18, 2016

synctext commented Oct 18, 2016

synctext commented Oct 18, 2016

synctext commented Oct 19, 2016

synctext commented Oct 19, 2016

synctext commented Oct 19, 2016

synctext commented Oct 19, 2016

devos50 left a comment

Choose a reason for hiding this comment

devos50 Oct 19, 2016

Choose a reason for hiding this comment

ardhipoetra commented Oct 19, 2016

ardhipoetra commented Jul 2, 2016 •

edited

Loading

ardhipoetra commented Jul 2, 2016 •

edited

Loading

ardhipoetra commented Jul 15, 2016 •

edited

Loading

ardhipoetra commented Oct 18, 2016 •

edited

Loading