-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Include multichain tests in Jenkins build #1784
Conversation
Minor fixes, thanks to @lfdversluis, fixes Tribler#1727 Minor changes to the guides
Moved export ouside if statement
Added advise to download libtorrent 1.0.6 on Windows instead of the latest version (1.0.7).
To make sure windows doesn't link libvlc.dll against the first random libvlccore.dll it finds.
Fixed arguments Closed BIO.MemoryBuffer after we're done Windows openssl applink fix Fixed arguments Closed BIO.MemoryBuffer after we're done Added comment
away from the GUI code. Show the ratio on the info panel too when seeding.
Moved the initialization of X11 threads to a seperate file Moved if-statement to the utility method
It still is a bit too buggy for it to be enabled in a stable release.
Turns out RawConfigParser constructor doesn't understand sections on the defaults dict and makes a mess of the config file.
Fixed dash (unicode issue) Minor change Made the statement about the PATH variable during the Python installation bold. My bad
@NielsZeilemaker @pimveldhuisen and @ Ewout (please leave your accountname here) This is the new PR for the multichain community. Two new students are taking this over, after Steffan defended his thesis work last week. #1429 is depricated. We need a list if items to address and merge this work. Read Niels his comments and add:
Still on the ToDo list are the SignAnything feature, planned for after this PR. Crawler code needs improvement and next task is making each community member collect records using a random walk. |
Delay the squashing as much as possible so you don't mix up your changes with the already existing ones, it will make your life easier. |
Also undo the merge from devel and do a proper rebase instead. |
another future feature: edge traversal needs churn resilience, keep-alive to barter partners. |
The SignAnything policy is not currently viable because your own total is calculated based on the data from the request. This should be done based on your own counters. |
@pimveldhuisen I fixed the candidate bugs in the gumby experiments. You should expect a PR asap. |
Discussed the session counters with @synctext. They reset when someone restarts the client, leading to inconsistent state (or opinions of how much up and download there has been). @synctext refuses to store the session counters in a database, since this is not simple. Dito for keeping timestamps in the counters. Thus I suggest applying a decay to the counters. A percentage decay every so many seconds/minutes/hours with a minimal threshold before deleting the counter. Easy to implement and doesn't add state. Such a decay means that long running clients will eventually converge to 0, the same state that new or restarted clients have. |
I guess these counters are per MID right? what's so hard about keeping a table that holds (MID, last_contact, counter) and gets cleaned up every now and then? Am I'm missing something? |
@whirm @Captain-Coder Then we can measure it, understand how it functions, and can incrementally improve it in various sprints. |
Do a rebase against |
Superseded by #1843 |
See if multichain tests succeed in Jenkins and expand them/create pretty pictures