Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Include multichain tests in Jenkins build #1784

Closed
wants to merge 53 commits into from

Conversation

pimveldhuisen
Copy link
Member

See if multichain tests succeed in Jenkins and expand them/create pretty pictures

snorberhuis and others added 30 commits November 12, 2015 14:00
Minor fixes, thanks to @lfdversluis, fixes Tribler#1727

Minor changes to the guides
Moved export ouside if statement
Added advise to download libtorrent 1.0.6 on Windows instead of the latest version (1.0.7).
To make sure windows doesn't link libvlc.dll against the first random
libvlccore.dll it finds.
Fixed arguments

Closed BIO.MemoryBuffer after we're done

Windows openssl applink fix

Fixed arguments

Closed BIO.MemoryBuffer after we're done

Added comment
away from the GUI code.

Show the ratio on the info panel too when seeding.
Elric Milon and others added 8 commits December 10, 2015 17:43
Moved the initialization of X11 threads to a seperate file

Moved if-statement to the utility method
It still is a bit too buggy for it to be enabled in a stable release.
Turns out RawConfigParser constructor doesn't understand sections on the
defaults dict and makes a mess of the config file.
Fixed dash (unicode issue)

Minor change

Made the statement about the PATH variable during the Python installation bold.

My bad
@synctext
Copy link
Member

@NielsZeilemaker @pimveldhuisen and @ Ewout (please leave your accountname here)

This is the new PR for the multichain community. Two new students are taking this over, after Steffan defended his thesis work last week. #1429 is depricated.

We need a list if items to address and merge this work. Read Niels his comments and add:

  • fix the re-introduce candidate bug in the gumby experiments.
  • dramatically reduce the blocksize and checking interval from 1 MByte and 1 second. 100MByte and 1 minute check should be much better choices.
  • disable community by default, no autoload.
  • the usual squash commits operation

Still on the ToDo list are the SignAnything feature, planned for after this PR. Crawler code needs improvement and next task is making each community member collect records using a random walk.
Finally, adding resilient to Sybil attack using novel random walk idea using genesis blocks.

@whirm
Copy link

whirm commented Dec 17, 2015

Delay the squashing as much as possible so you don't mix up your changes with the already existing ones, it will make your life easier.

@whirm
Copy link

whirm commented Dec 17, 2015

Also undo the merge from devel and do a proper rebase instead.

@synctext
Copy link
Member

another future feature: edge traversal needs churn resilience, keep-alive to barter partners.

@pimveldhuisen
Copy link
Member Author

The SignAnything policy is not currently viable because your own total is calculated based on the data from the request. This should be done based on your own counters.

@Captain-Coder
Copy link

@pimveldhuisen I fixed the candidate bugs in the gumby experiments. You should expect a PR asap.

@Captain-Coder
Copy link

Discussed the session counters with @synctext. They reset when someone restarts the client, leading to inconsistent state (or opinions of how much up and download there has been). @synctext refuses to store the session counters in a database, since this is not simple. Dito for keeping timestamps in the counters. Thus I suggest applying a decay to the counters. A percentage decay every so many seconds/minutes/hours with a minimal threshold before deleting the counter. Easy to implement and doesn't add state. Such a decay means that long running clients will eventually converge to 0, the same state that new or restarted clients have.

@whirm
Copy link

whirm commented Dec 22, 2015

I guess these counters are per MID right? what's so hard about keeping a table that holds (MID, last_contact, counter) and gets cleaned up every now and then? Am I'm missing something?

@synctext
Copy link
Member

@whirm @Captain-Coder
Yes, we can do simple accurate counters later. For now I think the best approach to get a mean&lean version deployed. As long as it "does no harm" to Tribler.

Then we can measure it, understand how it functions, and can incrementally improve it in various sprints.

@whirm
Copy link

whirm commented Dec 23, 2015

Do a rebase against devel, you are mixing up commits from devel with this branche's and it will be hell for you to fix afterwards.

@whirm whirm added the WIP label Dec 28, 2015
@pimveldhuisen pimveldhuisen mentioned this pull request Jan 5, 2016
3 tasks
@pimveldhuisen
Copy link
Member Author

Superseded by #1843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

9 participants