Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our Windows builder frequently leaves directories behind after the Tribler tests have finished #6603

Closed
devos50 opened this issue Dec 1, 2021 · 1 comment · Fixed by #6629

Comments

@devos50
Copy link
Contributor

devos50 commented Dec 1, 2021

Our tests are writing files to the /tmp directory and are not properly removed, at least on our Windows 64-bit machine that run the tests. See the following screenshot:

Schermafbeelding 2021-12-01 om 12 34 25

There seem to be two kind of directories that are left behind:

  • Directories named with ~10 random characters: they contain the following items:
    Schermafbeelding 2021-12-01 om 13 06 18
    This makes me suspect that these directories are left behind by a test that does something with downloading (e.g., our lib torrent or channel tests).
  • Directories that contain libtorrent metadata when doing DHT lookups. The directory is created here and should be cleaned-up here.
@qstokkink
Copy link
Contributor

For the second bullet point:

self.metadata_tmpdir = Path.mkdtemp(suffix='tribler_metainfo_tmpdir')

This temporary directory should be managed by the test suite. At least during the tests, this temporary directory should be created by pytest. Otherwise, should anything go wrong, nothing is managing the directory.

@drew2a drew2a self-assigned this Dec 7, 2021
@drew2a drew2a mentioned this issue Dec 7, 2021
drew2a added a commit that referenced this issue Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants