Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] TriblerTunnelCommunity max_peers set to 30 #6284

Closed
qstokkink opened this issue Aug 24, 2021 · 0 comments · Fixed by #6315
Closed

[main] TriblerTunnelCommunity max_peers set to 30 #6284

qstokkink opened this issue Aug 24, 2021 · 0 comments · Fixed by #6315
Assignees
@drew2a
Labels
status: broken

Comments

@qstokkink
Copy link
Contributor

tribler/src/tribler-core/tribler_core/components/implementation/tunnels.py

Line 51 in 5cb1ee0

ipv8.strategies.append((RandomWalk(community), 30))

This makes the target_peers equal to the max_peers for this community. This causes a deformed network topology and makes it harder for peers to connect to others. This should be set to the default value of 20 (like before https://github.com/Tribler/tribler/blob/release/7.10/src/tribler-core/tribler_core/modules/ipv8_module_catalog.py#L155).

For more information: Tribler/py-ipv8#979 (comment)
drew2a added a commit to drew2a/tribler that referenced this issue Sep 16, 2021
@drew2a
Fix Tribler#6284
ca4fade
@drew2a drew2a mentioned this issue Sep 16, 2021
Merged
@drew2a drew2a self-assigned this Sep 16, 2021
drew2a added a commit that referenced this issue Sep 16, 2021
@drew2a
Merge pull request #6315 from drew2a/fix/6284
8baf4fc 
Fix #6284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drew2a drew2a

Labels
status: broken
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #6284 drew2a/tribler
2 participants
@qstokkink @drew2a