Skip first sys.argv on frozen environment

src/tribler-gui/tribler_gui/core_manager.py

@@ -80,6 +80,14 @@ def on_event_manager_initial_error(self, _):
         else:
             self.start_tribler_core()
 
+    def get_core_args_based_on_env(self):
+        # If the core is running on frozen environment, sys.argv[0] becomes tribler executable while
+        # running from source code, sys.argv[0] is run_tribler.py which is run by python runtime.
+        # So, we should skip the first argument to prevent argument parsing error on frozen environment
+        # so that the arguments are parsed correctly by ArgumentParser (see run_tribler.py)
+        sys_argv = sys.argv if not hasattr(sys, '_MEIPASS') else sys.argv[1:]
+        return sys_argv + ['--core']
+
     def start_tribler_core(self):
         self.use_existing_core = False
 
@@ -92,7 +100,7 @@ def start_tribler_core(self):
 
         core_args = self.core_args
         if not core_args:
-            core_args = sys.argv + ['--core']
+            core_args = self.get_core_args_based_on_env()
 
         self.core_process = QProcess()
         self.core_process.setProcessEnvironment(core_env)

src/tribler-gui/tribler_gui/tests/test_core_manager.py

@@ -64,3 +64,22 @@ def test_on_core_stdout_stderr_read_ready_os_error():
     # check that OSError exception is suppressed when writing to stdout and stderr
     core_manager.on_core_stdout_read_ready()
     core_manager.on_core_stderr_read_ready()
+
+
+@patch('tribler_gui.core_manager.EventRequestManager', new=MagicMock())
+def test_get_core_args_based_on_env():
+    import sys  # pylint: disable=import-outside-toplevel
+    # test that correct core arguments are composed based on frozen environment
+    core_manager = CoreManager(MagicMock(), MagicMock(), MagicMock(), MagicMock())
+
+    # Unfrozen environment
+    core_args = core_manager.get_core_args_based_on_env()
+    assert not hasattr(sys, '_MEIPASS')
+    assert '--core' in core_args
+    assert sys.argv[0] in core_args
+
+    # Frozen environment
+    sys._MEIPASS = __file__  # pylint: disable=protected-access
+    core_args = core_manager.get_core_args_based_on_env()
+    assert '--core' in core_args
+    assert sys.argv[0] not in core_args