Added tasks tutorial #1027
Merged
Added tasks tutorial #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
validate |
|
The remaining Flake 8 and Pylint errors are due to the documentation import system and the usage of prints. Marking this as ready. Instead of having to compile this PR yourself, please enjoy this complementary PNG render:
|
devos50
reviewed
Jul 26, 2021
doc/basics/tasks_tutorial.rst
Outdated
|
|
||
| For your convenience, every ``Community`` is also a ``TaskManager``. | ||
| However, try to avoid spawning any tasks in the ``__init__`` of your ``Community``. | ||
| Specifically, you could end up scheduling a task in between your ``Community`` and other ``Community`` initialization |
There was a problem hiding this comment.
This sentence is missing a period.
doc/basics/tasks_tutorial.rst
Outdated
| .. literalinclude:: tasks_tutorial_6.py | ||
| :lines: 18-26 | ||
|
|
||
| Network IO and the DiscoveryStrategy |
There was a problem hiding this comment.
This part feels a bit detached from the overall story which is mostly about the task manager. Maybe you could move it to a separate tutorial file?
|
validate |
qstokkink
commented
Jul 26, 2021
Comment on lines
+1
to
+8
| Network IO and the DiscoveryStrategy | ||
| ==================================== | ||
|
|
||
| This document assumes you have a basic understanding of asyncio tasks, as documented in `the tasks tutorial <../../basics/tasks_tutorial>`_. | ||
| You will learn how to use the IPv8's ``DiscoveryStrategy`` class to avoid network congestion. | ||
|
|
||
| The DiscoveryStrategy | ||
| --------------------- |
There was a problem hiding this comment.
@devos50 These lines and the next section heading are new since your last review.
devos50
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #977
This PR:
DiscoveryStrategycreation.These are the basics required to take #979 off of "on hold".