-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curve25519 support #385
Curve25519 support #385
Conversation
community version 3 and higher by default.
I'm using the dual key modal, as explained here https://libnacl.readthedocs.org/en/latest/topics/dual.html this allows us to easily add encryption/descryption using the same keys. |
Merged build triggered. |
Merged build started. |
Merged build finished. |
Test FAILed. |
@whirm the test fail due to the missing dependencies, could you fix those? |
@whirm ill commit a small change soon which improves te key_to_bin stuff. |
@NielsZeilemaker done |
Merged build triggered. |
Merged build started. |
Merged build finished. |
Test FAILed. |
@whirm still doesn't seem to work, it seems that the dispersy tests aren't running inside the venv |
@NielsZeilemaker it doesn't seem to be packaged for Debian/Ubuntu. Let me see what options we have. |
Libsodium seems to be there https://launchpad.net/ubuntu/+source/libsodium |
Yes, but not the python bindings. So we either package them and provide two .debs, add another submodule or just copy the files you need to our repo... |
@NielsZeilemaker I think the best would be for you to add it as a submodule: https://github.com/saltstack/libnacl |
I'll have a go |
@whirm I failed, i'm not able to get it to work. I'm stuggeling with the additional folders in the repo. Do you have any pointers? |
I would just add the module dir to the pythonpath manually |
Tried that, failed as well |
@NielsZeilemaker sent you a pull request |
Curve25519
Merged build triggered. |
Merged build started. |
Merged build finished. |
Test FAILed. |
@whirm almost, now it can find libsodium
|
retest this please |
Merged build triggered. |
Merged build started. |
Merged build finished. |
Test FAILed. |
Merged build triggered. |
Merged build started. |
Merged build finished. |
Test FAILed. |
retest this please |
@whirm its failing due to pylint checking libnacl, i'm trying to remove those files from pylint. If this attempt doesn't work, i'll let you fix it. |
Merged build triggered. |
Merged build started. |
Merged build finished. |
Test PASSed. |
@NielsZeilemaker is it ready? |
Jup 2015-01-02 11:50 GMT+01:00 Elric Milon [email protected]:
|
Implemented curve25519 support for dispersy, members can be constructed from a curve25519 key. This paves the way for the tunnelcommunity swtiching to curve25519 keys.
It uses
Tested barebone signing/verifying using test_crypto, signing/verifying using test_member.