Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cookbook): correct complete code examples #582

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

alvarosabu
Copy link
Member

Based on your feedback @andretchen0 now codeblocks are complete functional examples with hightlights. Let me know ✌️

@alvarosabu alvarosabu requested a review from andretchen0 March 8, 2024 10:32
@alvarosabu alvarosabu added the docs Improvements or additions to documentation label Mar 8, 2024
Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit cfe7394
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/65eb17f42b3e5d00081d1cae
😎 Deploy Preview https://deploy-preview-582--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@andretchen0 andretchen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a missing 's' in the imports.

docs/cookbook/orbit-controls.md Outdated Show resolved Hide resolved
Copy link
Contributor

@andretchen0 andretchen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, clicked 'Submit review' with the wrong option.

See missing 's' in imports above.

@alvarosabu alvarosabu merged commit b04e4aa into main Mar 8, 2024
7 checks passed
@alvarosabu alvarosabu deleted the docs/577-tres-docs-cookbookorbit-fixes branch March 8, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants