-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend catalog in cientos #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
alvarosabu
changed the title
Feature/25 extend catalog in cientos
feat: extend catalog in cientos
Dec 7, 2022
Hmm this is probably okay for now, but in the future we should further investigate it so we can stay away from using the window object |
wheatjs
approved these changes
Dec 8, 2022
I actually manage to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #25
Ok, this one has been crazy. I managed to solve all the issues with different Scene and catalog when extending from cientos,
using provide inject was the key since composable where duplicating instances (core had a catalog with uuid 'a' and cientos catalog uuid 'b' ) 🤪
Now is working, I also add the possibility to render slots in cientos, which means if you create for example a wrapper for TextGeometry in
cientos
, you could pass the material from the main app like this@wheatjs wdyt?