Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve release and installation with MacOS #47

Merged
merged 2 commits into from
Dec 27, 2021

Conversation

ciiiii
Copy link
Contributor

@ciiiii ciiiii commented Dec 22, 2021

What this PR does / why we need it:

  1. Support darwin arm64(m1 Mac) release and installation.
  2. Support brew install trendyol/trendyol-tap/kink --HEAD, just for someone what to use kink build with main branch.

Which issue(s) this PR related:
Implements second task on #20

Special notes for your reviewer:
This is my first PR to Trendyol open source, so i am very open to any kind of feedback!

@developer-guy
Copy link
Member

LGTM @ciiiii, thank you so much.

@developer-guy developer-guy merged commit b8e45f5 into Trendyol:main Dec 27, 2021
developer-guy added a commit that referenced this pull request Dec 23, 2024
Signed-off-by: Batuhan Apaydın <[email protected]>

fix(cmd): should not error out twice

Fixes #3

Signed-off-by: Furkan <[email protected]>

fix(run): update service if exist

Fixes #2

Signed-off-by: Furkan <[email protected]>

feat: license lint error fixed, detect and work with current namespace in kubeconfig, enhance delete message with force mode enabled

Fixes #1

Signed-off-by: Batuhan Apaydın <[email protected]>

feat(load): pull image if it is not exist on locally

Fixes #5

Signed-off-by: Batuhan Apaydın <[email protected]>

build: release cycle created with github actions

Signed-off-by: Batuhan Apaydın <[email protected]>

style: Update README.md

Signed-off-by: Batuhan Apaydın <[email protected]>

chore: impl cosign support

Signed-off-by: Furkan <[email protected]>

feat(images): change container image repository addresses

Signed-off-by: Batuhan Apaydın <[email protected]>

add docker-images

Signed-off-by: Furkan <[email protected]>

chore: user kindest/node instead

Signed-off-by: Furkan <[email protected]>

fix(doc): add new line

fix(doc): remove new line

fix(doc): add new line (#4)

Co-authored-by: Erkan Zileli <[email protected]>

chore(goreleaser): add homebrew integration (#5)

doc(completion): fix completion docs (#10)

fix(goreleaser): remove completions from brew

Signed-off-by: Erkan Zileli <[email protected]>

feat: make skip_upload true

Signed-off-by: Batuhan Apaydın <[email protected]>

build(deps): bump github.com/schollz/progressbar/v3 from 3.8.2 to 3.8.3 (#12)

* feat: make skip_upload true

Signed-off-by: Batuhan Apaydın <[email protected]>

* build(deps): bump github.com/schollz/progressbar/v3 from 3.8.2 to 3.8.3

Bumps [github.com/schollz/progressbar/v3](https://github.com/schollz/progressbar) from 3.8.2 to 3.8.3.
- [Release notes](https://github.com/schollz/progressbar/releases)
- [Commits](schollz/progressbar@v3.8.2...v3.8.3)

---
updated-dependencies:
- dependency-name: github.com/schollz/progressbar/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: Batuhan Apaydın <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

build(deps): bump github.com/AlecAivazis/survey/v2 from 2.2.16 to 2.3.2 (#11)

Bumps [github.com/AlecAivazis/survey/v2](https://github.com/AlecAivazis/survey) from 2.2.16 to 2.3.2.
- [Release notes](https://github.com/AlecAivazis/survey/releases)
- [Commits](AlecAivazis/survey@v2.2.16...v2.3.2)

---
updated-dependencies:
- dependency-name: github.com/AlecAivazis/survey/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

docs(readme): add new badges

feat: add .golangci.yaml

feat: add test workflow

docs(readme): edit badges

feat(goreleaser): add go proxy

fix: lint,fmt issues

Signed-off-by: Batuhan Apaydın <[email protected]>

fix: github release project name

Signed-off-by: Batuhan Apaydın <[email protected]>

fix: change binary name

Signed-off-by: Batuhan Apaydın <[email protected]>

fix: add go 1.17.x to the matrix, remove dockerfile (#14)

Signed-off-by: Erkan Zileli <[email protected]>

feat: add completions script for goreleaser (#13)

Signed-off-by: Erkan Zileli <[email protected]>

fix: use only go1.17 on matrix for test workflow (#15)

Signed-off-by: Erkan Zileli <[email protected]>

fix: golint issues are fixed

Signed-off-by: Erkan Zileli <[email protected]>

docs(readme): fix commands, add homebrew installation section

Signed-off-by: Batuhan Apaydın <[email protected]>

docs(readme): remove sign/verify paragraphs

docs(readme): make bold binary installation path

feat: codecov support (#26)

Fix hello-world command example (#27)

feat: improve release and installation with MacOS (#47)

build(deps): bump github.com/schollz/progressbar/v3 from 3.8.3 to 3.8.5 (#46)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants