Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbin/tpm2-evt-log-parser.awk: Fix reference to uninitialized element #12

Merged
merged 1 commit into from
May 29, 2024

Conversation

miczyg1
Copy link

@miczyg1 miczyg1 commented May 24, 2024

Fixes the issue with reference to uninitialized element :

Entry 2:
    PCR:        255
    Event Type: 0x401
    Digests:
      SHA256: 0000000000000000000000000000000000000000000000000000000000000000
gawk: /usr/sbin/tpm2-evt-log-parser.awk:67: (FILENAME=/tmp/log.bin FNR=1) fatal: reference to uninitialized element `SYMTAB["SHA256_255"] is not allowed'

The PCR mapping event uses the PCR 0xff according to Intel TXT MLE Software Development Guide.

@miczyg1 miczyg1 force-pushed the tpm_evt_log_parsing_txt branch from b3902f4 to 9bdb517 Compare May 24, 2024 11:27
@miczyg1 miczyg1 requested a review from krystian-hebel May 24, 2024 11:29
Copy link
Member

@krystian-hebel krystian-hebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add the same also to txt-tpm1-evt-log-parser.awk so it won't surprise us later.

@miczyg1 miczyg1 force-pushed the tpm_evt_log_parsing_txt branch from 9bdb517 to a07f5a6 Compare May 24, 2024 11:45
@miczyg1
Copy link
Author

miczyg1 commented May 24, 2024

LGTM, but please add the same also to txt-tpm1-evt-log-parser.awk so it won't surprise us later.

Done

@miczyg1
Copy link
Author

miczyg1 commented May 29, 2024

@krystian-hebel ping

@krystian-hebel krystian-hebel merged commit a07f5a6 into main May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants