Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected pcrs #11

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Expected pcrs #11

merged 2 commits into from
Apr 17, 2024

Conversation

krystian-hebel
Copy link
Member

Added ability to print expected PCR values in order to easier catch any potential issues.

@krystian-hebel
Copy link
Member Author

Not tested in this exact form yet, this was in big part manually rewritten because copying files between Qubes dom0 and development computer is hard.

This also changes the way hexdump is printed - it now includes newline
character. Other than that, no functional changes intended.

Signed-off-by: Krystian Hebel <[email protected]>
@krystian-hebel
Copy link
Member Author

After fixing file permissions and some typos it works as expected for TPM2.0.

Copy link
Member

@SergiiDmytruk SergiiDmytruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to look closer, but TPM1 script has an issue for sure.

sbin/txt-tpm1-evt-log-parser.awk Outdated Show resolved Hide resolved
Expected PCRs 17 and 18 values are now printed at the end of dump for
easier comparison with real values. The latter can be read with:

cat /sys/class/tpm/tpm0/pcr-sha{1,256}/1[78]

Signed-off-by: Krystian Hebel <[email protected]>
Copy link
Member

@SergiiDmytruk SergiiDmytruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values of PCR17 don't match on KGPE-16, but it's not the script's fault, it computes everything correctly. Maybe some package is missing one of the fixes.

@SergiiDmytruk SergiiDmytruk merged commit 2cda978 into main Apr 17, 2024
1 check passed
@SergiiDmytruk SergiiDmytruk deleted the expected_pcrs branch April 17, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants