Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/build.yml: Add GitHub actions for building QubesOS … #1

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

krystian-hebel
Copy link
Member

…packages

@krystian-hebel krystian-hebel marked this pull request as ready for review September 29, 2023 11:19
@krystian-hebel krystian-hebel force-pushed the enable_ci branch 7 times, most recently from 32cd83a to 33a0842 Compare September 29, 2023 13:23
@krystian-hebel krystian-hebel marked this pull request as draft September 29, 2023 13:45
@krystian-hebel krystian-hebel force-pushed the enable_ci branch 3 times, most recently from 5c7b5af to 5c81c08 Compare September 29, 2023 15:03
@krystian-hebel krystian-hebel marked this pull request as ready for review September 29, 2023 15:03
@krystian-hebel
Copy link
Member Author

Requires TrenchBoot/.github#1 to be merged first.

Copy link
Member

@SergiiDmytruk SergiiDmytruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why GitHub doesn't show CI runs for this PR. Conditions are satisfied, so it should try to run CI here.

@krystian-hebel
Copy link
Member Author

It doesn't because there are not satisfied on main, it seems that only the target branch matters in this case. They can be forced by adding pull_request, which is (in addition to forced branch on https://github.com/TrenchBoot/.github) what I did to get https://github.com/TrenchBoot/qubes-antievilmaid/actions/runs/6352630738

@SergiiDmytruk
Copy link
Member

Hm, I thought the difference between pull_request and pull_request_target is in what branch name is matched against patterns (PR's or PR's target) which is wrong, it's about where to get configuration data.

I added filters for xen and grub because there are multiple branches some of which aren't related to AEM, maybe here that's not needed and all pushes can be handled. Or keep it as as because after merging the PR future PRs should be run on CI as well, but testing CI changes will be harder.

@krystian-hebel
Copy link
Member Author

I think it still is how you describe it, except that pull_request_target is fired on the target branch, with all its files, which includes CI settings.

I can change it for this repo, it's not like there is much compilation to do for this component anyway.

@krystian-hebel
Copy link
Member Author

krystian-hebel commented Sep 29, 2023

Everything seems to be working. I removed push because it ran CI twice, and pull_request should include everything we need anyway, according to https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request:

For example, if no activity types are specified, the workflow runs when a pull request is opened or reopened or when the head branch of the pull request is updated.

@SergiiDmytruk SergiiDmytruk merged commit cde735f into main Sep 29, 2023
1 check passed
@SergiiDmytruk SergiiDmytruk deleted the enable_ci branch September 29, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants