Set usable and safe client-side rate limit on Kubernetes client #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xabier Larrakoetxea <[email protected]>
|
i'm OK with defaults, but i think we should have parameters to set these options. |
|
Closing in favor of #51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Same PR as jetstack#203 :) many thanks for the effort of this fork!
Hi!
First of all, thanks for this awesome project!
We started using kube-oidc-proxy to access our clusters. Normally when a user uses the proxy to access a Kubernetes cluster, there isn't any problem, and works like a charm. However, when a machine/bot/app (e.g ArgoCD) starts using it the proxy starts rate-limiting the requests because the Kubernetes client client-side rate limit is not configured.
For example, our Argo CD installation failed constantly connecting to the clusters (get status, send actions...) because of this client-side rate limit.
This PR adds a safe default that it's known that works correctly:
QPS: 100
Burst: 100
Some projects that configure this to don't get this kind of problems:
Prometheus operator
Cert manager