Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20140707_005530 - 20140707_005532; 20150317_003413 & 003472 #863

Closed
wants to merge 2 commits into from
Closed

20140707_005530 - 20140707_005532; 20150317_003413 & 003472 #863

wants to merge 2 commits into from

Conversation

WorksWellWithOthers
Copy link
Contributor

Line 3413
Line 3472
Line 5530 - Line 5532

released, I would like to help out with the translations.

I just did a few lines to see if I'm compatible with the project. If not,
please let me know the things I have to change to help this process
smoother.

20150317_003413 & 003472

I tried to fill in the gaps, then read the Guideline. I jumped to an empty
chunk on the bottom

20140707_005530 - 20140707_005532

I have placed an "x" before the lines.
@terrapin47
Copy link
Contributor

Welcome! Please check the issue #850, and join us on discord ( instructions in the issue ).

@Ragunaga
Copy link
Contributor

It's better to just say what line number, instead of the string of numbers for each element.
Just an FYI for future reference to make it easier on you and everyone else, and also we shouldn't send any more pull requests in till the 23rd.

@WorksWellWithOthers
Copy link
Contributor Author

Thank you.

@Ragunaga
Copy link
Contributor

Oh, I also just noticed it now. You did the 'x's wrong. They should be before the file's name on each line.

eg. "xITEM#######_###### (stuff)"

If the x is before the file's name the devs can easilly remove them before compiling them back in the game. Since every x will have a uniform entity infront of it they can just find all "x(Prefix)" and replace with just "(Prefix)."

@WorksWellWithOthers
Copy link
Contributor Author

!!

Line 3472
Line 5530 - 5532
@imcgames
Copy link
Contributor

The Pull Request is closed for issues regarding copyrights as stated in our main page.
We will be updating you with details in the near future regarding this matter so please hold your Pull Requests until things the issue is resolved.
We apologize for the inconvenience caused.

@imcgames imcgames closed this Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants