-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treblle-ruby version 2 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KapustaB
force-pushed
the
refactor
branch
2 times, most recently
from
January 16, 2024 20:22
3da3d69
to
64e04c3
Compare
* add github action for specs * fix rakefile * remove action_dispatch * fix required dependancies * add gemfile
KapustaB
force-pushed
the
refactor
branch
7 times, most recently
from
January 26, 2024 13:00
f6faa3c
to
fb48449
Compare
KapustaB
force-pushed
the
refactor
branch
4 times, most recently
from
March 23, 2024 21:00
9aa4541
to
3fc26ce
Compare
KapustaB
force-pushed
the
refactor
branch
8 times, most recently
from
March 24, 2024 17:58
f6be93a
to
f54110a
Compare
KapustaB
force-pushed
the
refactor
branch
2 times, most recently
from
March 24, 2024 19:08
5cbe093
to
291669c
Compare
KapustaB
force-pushed
the
refactor
branch
4 times, most recently
from
March 25, 2024 18:26
43cad3b
to
8c86c1b
Compare
KapustaB
force-pushed
the
refactor
branch
2 times, most recently
from
March 25, 2024 19:10
97a02be
to
e590155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR is refactoring of the original
treblle-ruby
SDK and introduces numerous improvements.Improvements introduced:
ruby >= 3.0
rails >= 6.1
withgemfile.lock
for each releaseDescription:
Not properly working SDK and introducing improvements was the main motivation for introducing this PR.
Testing:
To run all specs locally:
To run specs on all supported versions of Rails: