Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treblle-ruby version 2 #2

Merged
merged 38 commits into from
Mar 25, 2024
Merged

treblle-ruby version 2 #2

merged 38 commits into from
Mar 25, 2024

Conversation

KapustaB
Copy link
Collaborator

@KapustaB KapustaB commented Jan 16, 2024

Summary:

This PR is refactoring of the original treblle-ruby SDK and introduces numerous improvements.

Improvements introduced:

  • replaced direct usage of ENVs for configuring SDK in Rails applications with configuration
  • improved structure and flexibility of the code overall
  • improved payload data sent to Treblle
  • added support for configuring additional sensitive attributes
  • added support for configuring restricted/blacklisted API paths that Treblle shouldn't monitor
  • added gemfile for dependencies
  • added rubocop rules (lint)
  • added rakefile for running specs and rubocop
  • added support for ruby >= 3.0
  • added support for rails >= 6.1 with gemfile.lock for each release
  • added tests
  • added github action to run tests on supported versions of ruby and rails
  • added MIT licence
  • added SECURITY notes

Description:

Not properly working SDK and introducing improvements was the main motivation for introducing this PR.

Testing:

To run all specs locally:

bundle exec rake rspec

To run specs on all supported versions of Rails:

bundle exec appraisal rspec

@KapustaB KapustaB force-pushed the refactor branch 2 times, most recently from 3da3d69 to 64e04c3 Compare January 16, 2024 20:22
@KapustaB KapustaB changed the title Refactor treblle-ruby version 2.0 Jan 17, 2024
KapustaB and others added 4 commits January 25, 2024 14:42
* add github action for specs

* fix rakefile

* remove action_dispatch

* fix required dependancies

* add gemfile
@KapustaB KapustaB force-pushed the refactor branch 7 times, most recently from f6faa3c to fb48449 Compare January 26, 2024 13:00
@KapustaB KapustaB force-pushed the refactor branch 4 times, most recently from 9aa4541 to 3fc26ce Compare March 23, 2024 21:00
@KapustaB KapustaB force-pushed the refactor branch 8 times, most recently from f6be93a to f54110a Compare March 24, 2024 17:58
@KapustaB KapustaB force-pushed the refactor branch 2 times, most recently from 5cbe093 to 291669c Compare March 24, 2024 19:08
@KapustaB KapustaB force-pushed the refactor branch 4 times, most recently from 43cad3b to 8c86c1b Compare March 25, 2024 18:26
@KapustaB KapustaB force-pushed the refactor branch 2 times, most recently from 97a02be to e590155 Compare March 25, 2024 19:10
@KapustaB KapustaB changed the title treblle-ruby version 2.0 treblle-ruby version 2 Mar 25, 2024
@KapustaB KapustaB merged commit 3e62bbc into master Mar 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant