Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for draft prs #30

Merged
merged 10 commits into from
May 4, 2020
Merged

Conversation

lfkwtz
Copy link
Contributor

@lfkwtz lfkwtz commented Apr 7, 2020

No description provided.

@lfkwtz
Copy link
Contributor Author

lfkwtz commented Apr 7, 2020

chose to go with 'y' / 'n' since getInput returns a string to keep it clearly non-boolean - but open to 'true' / 'false' or any preference of yours

Copy link
Owner

@TreTuna TreTuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to use true/false here as it makes more sense. Understanding the limitation of core.getInput we can work around that making a comparison to the string of "true" when we make the call and that will convert it to the boolean.

dist/index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
dist/index.js Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lfkwtz and others added 7 commits April 22, 2020 08:20
Co-Authored-By: Tré Ammatuna <[email protected]>
Co-Authored-By: Tré Ammatuna <[email protected]>
Co-Authored-By: Tré Ammatuna <[email protected]>
Co-Authored-By: Tré Ammatuna <[email protected]>
Co-Authored-By: Tré Ammatuna <[email protected]>
Co-Authored-By: Tré Ammatuna <[email protected]>
Co-Authored-By: Tré Ammatuna <[email protected]>
@TreTuna TreTuna merged commit 1290e33 into TreTuna:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants