✂️ metal: Qualified use cleanup #250
Merged
+54
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could do the same in the example and docs probably? |
Would be nice, all of the structs in objc2_metal start with MTL anyway to disambiguate them. |
Jasper-Bekkers
approved these changes
Oct 3, 2024
I was thinking of that more as a reason for importing them in scope rather than renaming the (optional) qualification. The |
MarijnS95
changed the title
Some items are imported in scope with `as _` and then again referenced using fully-qualified syntax. Clean that up, and drop the `use objc2_metal as metal` rename while at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some items are imported in scope with
as _and then again referenced using fully-qualified syntax. Clean that up, and drop theuse objc2_metal as metalrename while at it.Turns out Mac's aren't good at pushing code after all because this was scheduled to be part of the previous PR, but somehow missed out.