Avoid allocating strings when formatting allocation byte-sizes #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
reviewed
Jul 18, 2024
nical
force-pushed
the
fmtbytes
branch
2 times, most recently
from
3d6b3a2
to
d68764b
Compare
MarijnS95
approved these changes
Jul 18, 2024
MarijnS95
approved these changes
Jul 22, 2024
|
Seems quite coincidental that that Rust release notes suggest a nice way of writing this loop too: https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#exclusive-ranges-in-patterns |
Nice. Is it worth the msrv bump, though? wgpu has to lag a few rustc versions behind, so I'd appreciate if we shelf the nicer version for later. |
manon-traverse
approved these changes
Oct 15, 2024
Wasn't intending to bump just to use |
MarijnS95
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not particularly important but while I was adding integration in wgpu for the allocator reports and duplicating a bit of the formatting code in the process, it was rubbing me the wrong way to allocate strings in
fmt_byteswhen a Display impl could do the same without allocating, so I made the change there. Now I wrote the slightly better version, might as well contribute it back to its original spot!