Merge pull request #79 from Travelport-Ukraine/dev

Milestone 0.1.1

examples/generateFromList.js

@@ -15,7 +15,7 @@ const UserValidationErrors = createErrorsList({
 }, UserValidationError);
 
 
-try{
+try {
   try {
     throw new UserValidationErrors.NO_NAME({ user: { name: null } });
   } catch (e) {

examples/index.js

@@ -1 +1 @@
-const g = require('./generateFromList');
+require('./generateFromList');

package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-errors-helpers",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "Some helpers for better error handling in Node.js",
   "main": "index.js",
   "files": [
@@ -31,7 +31,7 @@
     "chai": "^3.5.0",
     "eslint": "^3.6.0",
     "eslint-config-airbnb": "^12.0.0",
-    "eslint-plugin-import": "^2.0.1",
+    "eslint-plugin-import": "^1.16.0",
     "eslint-plugin-jsx-a11y": "^2.2.2",
     "eslint-plugin-react": "^6.3.0",
     "mocha": "^3.0.2",

src/error-factory.js

@@ -1,6 +1,11 @@
 const util = require('util');
 
 const errorFactory = (name, message, baseType) => {
+  if (baseType && baseType !== Error) {
+    if ((typeof baseType) !== 'function' || (!(baseType.prototype instanceof Error))) {
+      throw new Error('baseType prototype should be an instance of Error');
+    }
+  }
   const baseTypeName = baseType ? baseType.name : 'Error';
 
   /* eslint-disable prefer-template */

test/index.js

@@ -29,6 +29,17 @@ describe('Generators', () => {
       expect(BarError).to.be.a('Function');
       expect(BarError.name).to.equal('BarError');
     });
+    it('should create error class if Error passed explicitely', () => {
+      const BarError = createErrorClass('BarError', BAR_ERROR_MESSAGE, Error);
+      expect(BarError).to.be.a('Function');
+      expect(BarError.name).to.equal('BarError');
+    });
+    it('should fail if baseType is not an error', () => {
+      const createErrorWithBadBaseType = () => {
+        return createErrorClass('BarError', BAR_ERROR_MESSAGE, {});
+      };
+      expect(createErrorWithBadBaseType).to.throw(Error);
+    });
     it('should create error instance without data', () => {
       const BarError = createErrorClass('BarError', BAR_ERROR_MESSAGE);
       const be = new BarError();