Skip to content

Commit

Permalink
Merge pull request #10 from TransmitSecurity/release/1.0.2
Browse files Browse the repository at this point in the history
release/1.0.2 --> master
  • Loading branch information
ts-omar authored Aug 25, 2022
2 parents 3d74144 + 8ae1688 commit 5271fa7
Show file tree
Hide file tree
Showing 12 changed files with 827 additions and 704 deletions.
15 changes: 14 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ For more, see [BindID Admin Portal: Get Started](https://developer.bindid.io/doc


#### Android Setup:
Please follow the [Android Redirection setup](https://developer.bindid.io/docs/guides/quickstart/topics/quickstart_android#step-4-set-up-redirection) to support deeplink in your app.
Please follow The [Android Integration setup](https://developer.bindid.io/docs/guides/quickstart/topics/quickstart_android#step-2-add-sdk-to-your-project) and [Android Redirection setup](https://developer.bindid.io/docs/guides/quickstart/topics/quickstart_android#step-4-set-up-redirection) to support deeplink in your app.

-----------

Expand Down Expand Up @@ -209,3 +209,16 @@ Transmit Security, https://github.com/TransmitSecurity

This project is licensed under the MIT license. See the LICENSE file for more info.

## Troubleshooting

#### M1 arch chip

1. If you have an issue running the example project on the M1 arch chip, There is a workaround solution from Apple, [Apple Rosetta](https://support.apple.com/en-us/HT211861) that enables a Mac with Apple silicon to use apps built for a Mac with an Intel processor.

2. There is another solution by excluding arm64 for the simulator architecture, both from your project and the Pod project. [Stackoverflow](https://stackoverflow.com/a/63955114).


#### Android compile issues

If you have an issue running the example project on Android, May you should change in the example app `package.json` file the **Expo** version to `44.0.6` and the **react-native** version to `0.68.2`.

2 changes: 1 addition & 1 deletion bindid-react-native.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ require "json"
package = JSON.parse(File.read(File.join(__dir__, "package.json")))

Pod::Spec.new do |s|
s.name = package["name"]
s.name = package["podname"]
s.version = package["version"]
s.summary = package["description"]
s.homepage = package["homepage"]
Expand Down
5 changes: 5 additions & 0 deletions docs/release-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ Template
#### EXPECTED MIGRATION CHANGES
--->

## 1.0.2 - August 2022
### Content
#### Bug Fixes
1. Fixed an issue where the current package.json name is not a valid name for a pod.

## 1.0.1 - August 2022
### Content
### Upgrade
Expand Down
2 changes: 1 addition & 1 deletion example/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Open `example/src/env.ts` and setup your ClientID and Redirect URI
#### Android Setup:
1. Open `example/android` in Android studio.
2. Open `BindidReactNativeExample/app/src/main/res/values/strings.xml`.
3. Change `bid_scheme` and `bid_host` according to your `RedirectURI`.
3. Change `bid_scheme` and `bid_host` according to your `RedirectURI`. Note: `bid_scheme` must be lowercase

Based on the `rnbindidexample://login` example, `bid_scheme` should be `rnbindidexample` and `bid_host` should be `login`

Expand Down
2 changes: 1 addition & 1 deletion example/babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module.exports = {
{
extensions: ['.tsx', '.ts', '.js', '.json'],
alias: {
[pak.name]: path.join(__dirname, '..', pak.source),
[pak.podname]: path.join(__dirname, '..', pak.source),
},
},
],
Expand Down
5 changes: 3 additions & 2 deletions example/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,12 @@ target 'BindIdAppExample' do
react_native_post_install(installer)
__apply_Xcode_12_5_M1_post_install_workaround(installer)
installer.pods_project.targets.each do |target|
if target.name == "bindid-react-native"
#if target.name == "bindid-react-native"
target.build_configurations.each do |config|
config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '13.0'
config.build_settings['EXCLUDED_ARCHS[sdk=iphonesimulator*]'] = "arm64"
end
end
#end
end
end

Expand Down
6 changes: 3 additions & 3 deletions example/ios/Podfile.lock
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
PODS:
- bindid-react-native (1.0.1):
- bindid-react-native (1.0.2):
- React-Core
- XmBindIdSDK (~> 1.30.0)
- boost (1.76.0)
Expand Down Expand Up @@ -516,7 +516,7 @@ EXTERNAL SOURCES:
:path: "../node_modules/react-native/ReactCommon/yoga"

SPEC CHECKSUMS:
bindid-react-native: 9d380e2758e0f8c5befa992fe556bf6fa2bb7b75
bindid-react-native: 903dbb76948e63798fe2102ad2ee5257dd422608
boost: a7c83b31436843459a1961bfd74b96033dc77234
CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99
DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54
Expand Down Expand Up @@ -568,6 +568,6 @@ SPEC CHECKSUMS:
Yoga: ff994563b2fd98c982ca58e8cd9db2cdaf4dda74
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a

PODFILE CHECKSUM: 4834fe7f175cf6f4ef69f10061e36d8a0a6ba455
PODFILE CHECKSUM: 2afbee34aa701dd2f89f67316b91249dc6b498fa

COCOAPODS: 1.10.1
Loading

0 comments on commit 5271fa7

Please sign in to comment.