Merge pull request #6 from TranslatorSRI/pqfix

fixes a bug in pq_int
TranslatorSRI · Dec 18, 2023 · 0edf2ec · 0edf2ec
2 parents f145b6d + 4f27f6d
commit 0edf2ec
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 2 deletions.
diff --git a/src/descender.py b/src/descender.py
@@ -108,8 +108,7 @@ def create_pq_to_descendant_int_ids(self,rc):
         # Create a dictionary from pq to all of its descendant integer ids
         # First, pull the integer id for every pq
         pql = list(self.pq_to_descendants.keys())
-        pq_iids = rc.pipeline_gets(3, pql, True).values()
-        pq_int_ids = {pq:iid for pq,iid in zip(pql, pq_iids)}
+        pq_int_ids = rc.pipeline_gets(3, pql, True)
         # now convert pq_to_descendants into int id values
         pq_to_descendant_int_ids = {}
         for pq in self.pq_to_descendants:

diff --git a/tests/test_trapi.py b/tests/test_trapi.py
@@ -51,6 +51,52 @@ def test_profile_asthma():
     response = client.post("/query", json= query_graph).json()
     print("How many results?",len(response["message"]["results"]))
 
+def test_affects():
+    m = {
+      "message": {
+        "query_graph": {
+          "nodes": {
+            "subnode": {
+              "ids": [
+                "PUBCHEM.COMPOUND:70701426"
+              ]
+            },
+            "objnode": {
+              "categories": [
+                "biolink:Gene"
+              ]
+            }
+          },
+          "edges": {
+            "the_edge": {
+              "subject": "subnode",
+              "object": "objnode",
+              "predicates": [
+                "biolink:affects"
+              ],
+              "qualifier_constraints": [
+                {
+                  "qualifier_set": [
+                    {
+                      "qualifier_type_id": "biolink:object_aspect_qualifier",
+                      "qualifier_value": "activity"
+                    },
+                    {
+                      "qualifier_type_id": "biolink:object_direction_qualifier",
+                      "qualifier_value": "decreased"
+                    }
+                  ]
+                }
+              ]
+            }
+          }
+        }
+      }
+    }
+    response = client.post("/query", json=m)
+    print("How many results?",len(response.json()["message"]["results"]))
+    assert response.status_code == 200
+
 def test_500():
     # This is giving a 500, seems like it's getting into the double ended query by mistake.
     m = {