Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename /reverse_lookup?curies=X to /synonyms?preferred_curie=X #136

Closed
gaurav opened this issue Jan 13, 2024 · 0 comments · Fixed by #168
Closed

Rename /reverse_lookup?curies=X to /synonyms?preferred_curie=X #136

gaurav opened this issue Jan 13, 2024 · 0 comments · Fixed by #168

Comments

@gaurav
Copy link
Contributor

gaurav commented Jan 13, 2024

We've had several users this week who expected that /reverse_lookup would normalize the incoming CURIE as well, and being surprised when a secondary CURIE didn't work on NameRes without normalizing it through NodeNorm first. Renaming this to /synonyms?preferred_curie=X might make this clearer. We could also improve the documentation to make this clearer.

If/when we have a NameRes FAQ or a combined NodeNorm/NameRes Jupyter Notebook (#133), this might also be usefully explained there.

@gaurav gaurav added this to the NameRes March 2024 milestone Jan 13, 2024
gaurav added a commit that referenced this issue Oct 16, 2024
gaurav added a commit that referenced this issue Nov 4, 2024
We've had a lot of users getting confused because a CURIE that works in NodeNorm doesn't work in NameLookup -- this is because NameLookup's `/reverse_lookup` endpoint doesn't do any normalization. This PR deprecates those endpoints (while leaving them around), and adds new `/synonyms` endpoints, which explicitly call them `preferred_curies` and has a note in the description to indicate that NodeNorm should be used to get these. `/synonyms` isn't quite accurate, because really this endpoint returns all the information we have on that CURIE, including the suffix, taxon information and so on. But the obvious correct name (`/lookup`) is already in use for NameLookup's text search function.

Closes #136.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant