Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter tool #525

Merged
merged 33 commits into from
Jun 30, 2023
Merged

Twitter tool #525

merged 33 commits into from
Jun 30, 2023

Conversation

Tarraann
Copy link
Collaborator

@Tarraann Tarraann commented Jun 27, 2023

Description

Related Issues

Solution and Design

Test Plan

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update

Checklist

  • My pull request is atomic and focuses on a single change.
  • I have read the contributing guide and my code conforms to the guidelines.
  • I have documented my changes clearly and comprehensively.
  • I have added the required tests.

@neelayan7
Copy link
Collaborator

Tests are failing, please check @Tarraann

Copy link
Contributor

@DMTarmey DMTarmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

main.py Outdated
@@ -411,6 +428,40 @@ def get_google_calendar_tool_configs(toolkit_id: int):
"client_id": google_calendar_config.value
}

@app.get("/twitter/get_twitter_creds/toolkit_id/{toolkit_id}")
def get_twitter_tool_configs(toolkit_id: int):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this to twitter_auth.rb in controller.

@Tarraann Tarraann merged commit 074d5d1 into dev Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants