Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of relaxed time periods #59

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

zptro
Copy link
Contributor

@zptro zptro commented Sep 10, 2024

This PR enables producing evening transit LOS and using them in demand model.

As a separate step we should try model estimation without the "aht" LOS, to see if that time period can be dropped in demand calculation loop.

As suggested in this PR, we should also test replacing bike and walk distance with time and to entirely drop distance matrix from demand calculation. Mostly time is a proxy for distance, but when running the model for archipelago areas, there will be a difference in how people use ferries in walk mode. To be able to run the model with more LOS matrices (evening added) it was necessary to remove distance at least for the modes that do not use it in demand calculation.

TODO: Matrices and extra attributes in EMME are currently a mess! In a later PR, I will try to refactor all of that.

@zptro zptro requested a review from attesn September 10, 2024 13:44
Copy link
Contributor

@attesn attesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! However, I don't like the idea of including distance matrix drop to this update. Archipelago areas and ferries are such small portion of total traffic that other development work should be prioritized. On quick look there is < 0,2 % of population living in these areas and we many many open issues with the 80 percent.

Maybe we should also test the run with off peak period before merging? Therefore I didn't approve changes yet.

@zptro
Copy link
Contributor Author

zptro commented Sep 16, 2024

Looks good! However, I don't like the idea of including distance matrix drop to this update. Archipelago areas and ferries are such small portion of total traffic that other development work should be prioritized. On quick look there is < 0,2 % of population living in these areas and we many many open issues with the 80 percent.

Maybe we should also test the run with off peak period before merging? Therefore I didn't approve changes yet.

I restored distance matrices for walk and bike. To be able to run the model with more LOS matrices (evening added) it was necessary to remove distance at least for the modes that do not use it in demand calculation.

… into feat/relaxed_timeperiods

# Conflicts:
#	Scripts/tests/test_data/Network/netfield_links_test.txt
#	Scripts/tests/test_data/Network/netfield_transit_lines_test.txt
@attesn
Copy link
Contributor

attesn commented Nov 8, 2024

Työtila matrices have suffix "it" and here it seems to be "ilt". Which is preferred?

jmutikainen and others added 6 commits November 12, 2024 10:40
* Update demand parameters with evening hour shares

* Add demand model parameters for new time period
… into feat/relaxed_timeperiods

# Conflicts:
#	Scripts/datatypes/purpose.py
#	Scripts/tests/test_data/Network/netfield_links_test.txt
#	Scripts/tests/test_data/Network/netfield_transit_lines_test.txt
@zptro zptro marked this pull request as ready for review November 15, 2024 13:16
@zptro
Copy link
Contributor Author

zptro commented Nov 15, 2024

Työtila matrices have suffix "it" and here it seems to be "ilt". Which is preferred?

I will change the name to "it" everywhere, but aside from that, this PR seems to be finished.

@zptro zptro requested a review from attesn November 15, 2024 13:46
@attesn
Copy link
Contributor

attesn commented Nov 18, 2024

@zptro I think we'll need transit impedance matrices for pt with free flow based speeds (to match estimation with this PR model-system)? Estimation inluded was done only with updated it matrix.

@zptro
Copy link
Contributor Author

zptro commented Nov 19, 2024

@zptro I think we'll need transit impedance matrices for pt with free flow based speeds (to match estimation with this PR model-system)? Estimation inluded was done only with updated it matrix.

Updated time_pt matrices in sharepoint.

Copy link
Contributor

@attesn attesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zptro Ready! However it seems that my review is not valid as I added new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants