Enforce long-distance mode for long-distance assignment classes #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove count_zone_boardings artefacts inherited from helmet - Update docstrings
… into feat/long_distance_mode_enforcement # Conflicts: # Scripts/assignment/datatypes/transit.py
zptro
changed the title
juliuskroetzl
approved these changes
Aug 9, 2024
juliuskroetzl
previously approved these changes
Aug 9, 2024
attesn
previously approved these changes
Aug 16, 2024
|
This change makes model performance slightly worse. Maybe we should wait for other development options (access model, overnight leisure trips) to be completed first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may increase model run times somewhat, but removes need for hard-coded airplane cost threshold.
This is the same PR that was in Bitbucket earlier.