Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#54 Handle the release date in the deployment.json & response of GetReleaseInfo() #56

Merged
merged 1 commit into from
May 4, 2020
Merged

#54 Handle the release date in the deployment.json & response of GetReleaseInfo() #56

merged 1 commit into from
May 4, 2020

Conversation

tiwalter
Copy link
Collaborator

@tiwalter tiwalter commented May 1, 2020 •
edited
Loading

  • Extend the DeploymentMetaInfo and the corresponding unit test
  • Adjust the implementation of GetReleasInfo() in the FsReleaseArtifactRepository incl. the return types
  • Adjust the Controller function GetReleaseInfo() incl. the documentation
  • Adjust unit tests
  • Rename the ChangelogResponseModel to ReleaseInformationModel
  • Adjust the test_artifact_payload.zip file
  • Adjust the whole test data (deployment.json)
  • Remove the obsolete ConvertStringToChangelogResponse() function incl the corresponding unit test

@tiwalter
#54 Implement the handling of the "ReleaseDate" in the deployment.jso…
bedfd03 
…n & response of GetReleaseInfo()

- Extend the DeploymentMetaInfo and the corresponding unit test
- Adjust the implementation of GetReleasInfo() in the FsReleaseArtifactRepository incl. the return types
- Adjust the Controller function GetReleaseInfo() incl. the documentation
- Adjust unit tests
- Rename the ChangelogResponseModel to ReleaseInformationModel
- Adjust the test_artifact_payload.zip file
- Adjust the whole test data (deployment.json)
- Remove the obsolete ConvertStringToChangelogResponse() function incl the corresponding unit test
@tiwalter tiwalter linked an issue May 1, 2020 that may be closed by this pull request
GetReleaseInfo shall return the release date #54
Closed
@tiwalter tiwalter requested a review from f-porter May 1, 2020 21:20
@tiwalter tiwalter changed the title #54 Implement the handling of the "ReleaseDate" in the deployment.jso… #54 Handle the release date in the deployment.json & response of GetReleaseInfo() May 1, 2020
@tiwalter
Copy link
Collaborator Author

tiwalter commented May 1, 2020

@f-porter the new format of the deployment.json looks like:

{
    "ChangelogFileName": "changelog.txt",
    "ArtifactFileName": "artifact.zip",
    "ReleaseDate": "2020-02-10"
}

If you agree to this, you can merge the PR.

@tiwalter
Copy link
Collaborator Author

tiwalter commented May 4, 2020 •
edited
Loading

As discussed with @f-porter, the PR can be merged.

@tiwalter tiwalter merged commit 949c5fb into master May 4, 2020
@tiwalter tiwalter deleted the feature/add-release-date-to-get-release-info branch May 6, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-porter f-porter Awaiting requested review from f-porter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetReleaseInfo shall return the release date
1 participant
@tiwalter