Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a data validation after uploading #14

Closed
tiwalter opened this issue Nov 3, 2019 · 0 comments · Fixed by #58
Closed

Implement a data validation after uploading #14

tiwalter opened this issue Nov 3, 2019 · 0 comments · Fixed by #58
Assignees
@tiwalter
Labels
enhancement New feature or request user story
Milestone
Release Server v0...

Comments

@tiwalter
Copy link
Collaborator

tiwalter commented Nov 3, 2019 •
edited
Loading

Validation criteria:

  • Data <=500 MB
  • Zip contains all needed elements (contained in deployment.json)
  • Deployment.Json as expected
  • The payload has to be a valid .zip file
@tiwalter tiwalter changed the title Refactor the Upload Endpoint Refactor the upload endpoint Nov 3, 2019
@tiwalter tiwalter added enhancement New feature or request refactoring and removed enhancement New feature or request labels Nov 3, 2019
tiwalter added a commit that referenced this issue May 10, 2020
@tiwalter
#14 Move the extension methods from the "Common" folder to "Extensions"
75c1395
@tiwalter tiwalter self-assigned this May 10, 2020
tiwalter added a commit that referenced this issue May 10, 2020
@tiwalter
#14 Implement the data validation of the upload payload
e1c29b4 
- Implement the FSReleaseArtifactService function ValidateUploadPayload()
- Implement an extension method that validates the DeploymentMetaInfo
- Extend the TestUtils
- Extend the DeploymentMetaInfoMapper to support a mapping of byte arrays
- Write unit tests for the new implementations
- Rename the former "Common" namespaces to "Extensions"
- Add test data for the new unit tests
@tiwalter tiwalter changed the title Refactor the upload endpoint Implement a data validation after uploading May 10, 2020
@tiwalter tiwalter added enhancement New feature or request user story and removed future refactoring labels May 10, 2020
@tiwalter tiwalter added this to the Release Server v0.2 milestone May 10, 2020
@tiwalter tiwalter mentioned this issue May 10, 2020
Closed
tiwalter added a commit that referenced this issue May 10, 2020
@tiwalter
#14 Improve the error messages
3d54bc9
@tiwalter tiwalter linked a pull request May 10, 2020 that will close this issue
Implement a data validation after uploading #58
Merged
tiwalter added a commit that referenced this issue May 10, 2020
@tiwalter
#14 Rename DeploymentMetaInfo to DeploymentMetaInfoModel & adjust tes…
a985aee 
…t data
tiwalter added a commit that referenced this issue May 17, 2020
@tiwalter
#14 Implement the handling of an invalid Json file format
4305d5d 
- Implement an extension method that checks the json validity of a byte array
- Add the json validation to the ValidateUploadPayload() function
- Implement a helper function that converts a stream to a byte array
- Add test data
- Write unit tests
tiwalter added a commit that referenced this issue May 31, 2020
@tiwalter
#14 Remove the redundant "Model" suffix
014b059
tiwalter added a commit that referenced this issue May 31, 2020
@tiwalter
#14 Eliminate the ZipArchiveMapper class and use the JsonIgnore attri…
e15657b 
…bute to validate the DeploymentMetaInfo during json deserialization
tiwalter added a commit that referenced this issue May 31, 2020
@tiwalter
#14 Use a StreamReader and eliminate obsolete functions
3f9d9fb
tiwalter added a commit that referenced this issue Jun 2, 2020
@tiwalter
#14 Make ValidateUploadPayload() synchronous and fix unit tests
f79a7b0
tiwalter added a commit that referenced this issue Jun 2, 2020
@tiwalter
#14 Rename ReleaseArtifactModel to ReleaseArtifact
379a424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiwalter tiwalter

Labels
enhancement New feature or request user story
Projects
None yet
Milestone
Release Server v0.2.0
Development

Successfully merging a pull request may close this issue.

Implement a data validation after uploading Traeger-GmbH/release-server
1 participant
@tiwalter