Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for tags #551

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix: add support for tags #551

merged 1 commit into from
Jan 23, 2024

Conversation

arminioa
Copy link
Contributor

When we need to build images when a tag is created with this commit those images will be prefixed with tag-<SHA>. This way we can write ECR lifecycle polices which will filter images based on tag prefixes in order to decide how much time or how many images to keep.

When we need to build images when a tag is created
with this commit those images will be prefixed with
`tag-<SHA>`. This way we can write ECR lifecycle polices
which will filter images based on tag prefixes in order
to decide how much time or how many images to keep.
@arminioa arminioa requested review from a team as code owners January 23, 2024 15:38
Copy link
Contributor

@durzica durzica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arminioa arminioa merged commit 396c03f into master Jan 23, 2024
5 checks passed
@arminioa arminioa deleted the POPS-3158_add_support_on_tags branch January 23, 2024 16:14
Copy link

🎉 This PR is included in version 1.10.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants