feat: add constraintName to JoinColumn

Add a constraintName to JoinColumn decorators to allow specifying foreignKey name. Use constraintName when building JoinTable entities as well. Partially solves: typeorm#1355
TradeCast · Mar 29, 2022 · 487ceb4 · 487ceb4
1 parent bf4466b
commit 487ceb4
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/src/metadata-builder/JunctionEntityMetadataBuilder.ts b/src/metadata-builder/JunctionEntityMetadataBuilder.ts
@@ -160,11 +160,10 @@ export class JunctionEntityMetadataBuilder {
                         options: {
                             length:
                                 !inverseReferencedColumn.length &&
-                                (DriverUtils.isMySQLFamily(
-                                    this.connection.driver,
-                                ) ||
-                                    this.connection.driver.options.type ===
-                                        "aurora-mysql") &&
+                                (this.connection.driver instanceof
+                                    MysqlDriver ||
+                                    this.connection.driver instanceof
+                                        AuroraDataApiDriver) &&
                                 (inverseReferencedColumn.generationStrategy ===
                                     "uuid" ||
                                     inverseReferencedColumn.type === "uuid")
@@ -219,7 +218,7 @@ export class JunctionEntityMetadataBuilder {
                       referencedColumns: referencedColumns,
                       onDelete: relation.onDelete || "CASCADE",
                       onUpdate:
-                          this.connection.driver.options.type === "oracle"
+                          this.connection.driver instanceof OracleDriver
                               ? "NO ACTION"
                               : relation.onUpdate || "CASCADE",
                   }),
@@ -233,7 +232,7 @@ export class JunctionEntityMetadataBuilder {
                           ? relation.inverseRelation.onDelete
                           : "CASCADE",
                       onUpdate:
-                          this.connection.driver.options.type === "oracle"
+                          this.connection.driver instanceof OracleDriver
                               ? "NO ACTION"
                               : relation.inverseRelation
                               ? relation.inverseRelation.onUpdate

diff --git a/src/metadata/ColumnMetadata.ts b/src/metadata/ColumnMetadata.ts
@@ -284,6 +284,11 @@ export class ColumnMetadata {
      */
     constraintName?: string
 
+    /**
+     * If this column is foreign key then this specifies the name for it.
+     */
+    constraintName?: string
+
     /**
      * Specifies a value transformer that is to be used to (un)marshal
      * this column when reading or writing to the database.

diff --git a/src/metadata/ForeignKeyMetadata.ts b/src/metadata/ForeignKeyMetadata.ts
@@ -75,6 +75,11 @@ export class ForeignKeyMetadata {
      */
     givenName?: string
 
+    /**
+     * User specified unique constraint name.
+     */
+    givenName?: string
+
     // ---------------------------------------------------------------------
     // Constructor
     // ---------------------------------------------------------------------