Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataframe upgrade to 1.x #83

Merged
merged 3 commits into from
Aug 28, 2021
Merged

Dataframe upgrade to 1.x #83

merged 3 commits into from
Aug 28, 2021

Conversation

khosravipasha
Copy link
Contributor

Should wait to rerun tests here until the LC version is pushed.

Biggest changes are:

  1. Cannot do DataFrame(matrix) anymore, and need to either do DataFrame(matrix, :auto) or DataFrame(Tables.table(matrix)).

  2. Cannot use Base.convert for converting DataFrame to matrix, should use Tables.matrix(dataframe) instead.

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #83 (16e8f7f) into master (028d90c) will decrease coverage by 7.55%.
The diff coverage is 88.88%.

❗ Current head 16e8f7f differs from pull request most recent head 9f27ccd. Consider uploading reports for the commit 9f27ccd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   75.32%   67.76%   -7.56%     
==========================================
  Files          40       40              
  Lines        3036     3022      -14     
==========================================
- Hits         2287     2048     -239     
- Misses        749      974     +225     
Impacted Files Coverage Δ
src/queries/marginal_flow.jl 60.63% <ø> (-5.46%) ⬇️
src/queries/map.jl 55.81% <66.66%> (-17.83%) ⬇️
src/Utils/information.jl 38.29% <100.00%> (ø)
src/Utils/misc.jl 38.88% <100.00%> (-1.86%) ⬇️
src/mixtures/em.jl 100.00% <100.00%> (ø)
src/queries/sample.jl 46.00% <100.00%> (-16.00%) ⬇️
src/parameters.jl 61.22% <0.00%> (-31.64%) ⬇️
src/queries/expectation_bit.jl 85.00% <0.00%> (-15.00%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028d90c...9f27ccd. Read the comment docs.

@khosravipasha khosravipasha merged commit 290ab42 into master Aug 28, 2021
@khosravipasha khosravipasha deleted the dataframe-upgrade branch August 29, 2021 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants