Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "LoopVectorization" to "0.11" #54

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 1, 2021

This pull request changes the compat entry for the LoopVectorization package from 0.8.20 to 0.8.20, 0.11.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@khosravipasha khosravipasha force-pushed the compathelper/new_version/2021-02-01-01-08-45-777-2935123492 branch from 53bcc0d to 53c7605 Compare February 1, 2021 01:08
@khosravipasha
Copy link
Contributor

Need to remove vifelse as it seems it does not exist in new version:

LoadError: UndefVarError: vifelse not defined

Used in two places: https://github.com/Juice-jl/ProbabilisticCircuits.jl/search?q=vifelse

@khosravipasha khosravipasha added Breaking bug Something isn't working and removed bug Something isn't working labels Feb 25, 2021
@khosravipasha
Copy link
Contributor

Followed similar changes as Tractables/LogicCircuits.jl@90a16a5, it should work, will merge after tests pass.

@khosravipasha khosravipasha self-assigned this Feb 26, 2021
@khosravipasha khosravipasha force-pushed the compathelper/new_version/2021-02-01-01-08-45-777-2935123492 branch from 32662fb to ce7f164 Compare March 3, 2021 01:57
@khosravipasha
Copy link
Contributor

Expectation test fails sometimes but is not related to this change. Need to fix the random seed for it. Merging this.

@khosravipasha khosravipasha merged commit 8754915 into master Mar 3, 2021
@khosravipasha khosravipasha deleted the compathelper/new_version/2021-02-01-01-08-45-777-2935123492 branch March 3, 2021 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant