Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Em log and data softening #124

Merged
merged 6 commits into from
Oct 10, 2022
Merged

Em log and data softening #124

merged 6 commits into from
Oct 10, 2022

Conversation

MhDang
Copy link
Member

@MhDang MhDang commented Oct 10, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 42.05% // Head: 41.86% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (35db307) compared to base (e063c82).
Patch coverage: 6.25% of modified lines in pull request are covered.

❗ Current head 35db307 differs from pull request most recent head 0c9fe8a. Consider uploading reports for the commit 0c9fe8a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   42.05%   41.86%   -0.20%     
==========================================
  Files          23       23              
  Lines        1881     1892      +11     
==========================================
+ Hits          791      792       +1     
- Misses       1090     1100      +10     
Impacted Files Coverage Δ
src/parameters/em.jl 4.06% <0.00%> (-0.13%) ⬇️
src/nodes/indicator_dist.jl 66.66% <50.00%> (-2.09%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@guyvdbroeck
Copy link
Member

what is the meaning of flowflag?

@MhDang
Copy link
Member Author

MhDang commented Oct 10, 2022

That part is to compute the lower bound of pruning edges and I forgot to remove it. Will remove and re-commit.

@MhDang MhDang closed this Oct 10, 2022
@MhDang MhDang reopened this Oct 10, 2022
@MhDang MhDang merged commit fe10122 into master Oct 10, 2022
@MhDang MhDang deleted the em-log branch October 10, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants