Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binomial Input Nodes #119

Merged
merged 24 commits into from
Mar 16, 2022
Merged

Binomial Input Nodes #119

merged 24 commits into from
Mar 16, 2022

Conversation

khosravipasha
Copy link
Contributor

@khosravipasha khosravipasha commented Mar 14, 2022

Intitial Code for binomial input nodes, learning and sampling (on gpu) now works (see examples/binomial_mnist.jl).

Todos:

  • MAP GPU (debug; was throwing an error in the bigger circui, the tests are passing though)
  • How to handle missing flow? I think I might have wrong formula.
  • Add somes Tests
  • Save/Load for jpc format
  • Sample on CPU
  • MAP CPU

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #119 (c50f1a2) into master (0e28de4) will increase coverage by 1.18%.
The diff coverage is 53.21%.

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   41.94%   43.12%   +1.18%     
==========================================
  Files          22       23       +1     
  Lines        1726     1834     +108     
==========================================
+ Hits          724      791      +67     
- Misses       1002     1043      +41     
Impacted Files Coverage Δ
src/bits_circuit.jl 87.30% <0.00%> (-0.40%) ⬇️
src/io/plot.jl 88.88% <0.00%> (-11.12%) ⬇️
src/nodes/categorical_dist.jl 23.15% <0.00%> (+0.81%) ⬆️
src/nodes/input_distributions.jl 6.66% <0.00%> (ø)
src/queries/likelihood_cpu.jl 59.61% <0.00%> (ø)
src/structures/hclts.jl 74.72% <0.00%> (-1.42%) ⬇️
src/nodes/binomial_dist.jl 54.87% <54.87%> (ø)
src/io/jpc_io.jl 99.12% <100.00%> (+0.11%) ⬆️
src/nodes/abstract_nodes.jl 88.00% <0.00%> (+0.24%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e28de4...c50f1a2. Read the comment docs.

@khosravipasha khosravipasha marked this pull request as ready for review March 16, 2022 02:20
@khosravipasha khosravipasha changed the title [WIP] Binomial Input Nodes Binomial Input Nodes Mar 16, 2022
@khosravipasha khosravipasha merged commit eed7d83 into master Mar 16, 2022
@khosravipasha khosravipasha deleted the binomial branch January 6, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant