add implied literals #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 81.92% 82.04% +0.12%
==========================================
Files 29 29
Lines 2373 2389 +16
==========================================
+ Hits 1944 1960 +16
Misses 429 429
Continue to review full report at Codecov.
|
khosravipasha
approved these changes
Jan 20, 2021
| @@ -223,6 +224,40 @@ function isdeterministic(root::LogicCircuit)::Bool | |||
| result | |||
| end | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I guess you could also add a doc string to describe input/outputs and what implied_literals means a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add functionality and testing for computing the implied literals at every node of a logic circuit