Create Building_LLVM.md #1448
Closed
Create Building_LLVM.md #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM blog
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
reviewed
Nov 1, 2024
There was a problem hiding this comment.
FYI the vale warnings are also visible at https://github.com/TraceMachina/nativelink/pull/1448/files
In this case you can do the following:
- Instead of rustc, write
rustcwith backticks. - Add ROCm to the global accept.txt file here: https://github.com/TraceMachina/nativelink/blob/main/.github/styles/config/vocabularies/TraceMachina/accept.txt
Reviewable status: 0 of 1 LGTMs obtained, and 0 of 1 files reviewed, and pending CI: Cargo Dev / macos-13, Coverage, Installation / macos-13, Installation / macos-14, Remote / large-ubuntu-22.04, Web Platform Deployment / macos-14, Web Platform Deployment / ubuntu-24.04, macos-13, pre-commit-checks, vale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM blog
This change is