Skip to content

Commit

Permalink
Fix issue when generating a template for helm3 where the chart versio…
Browse files Browse the repository at this point in the history
…n was not passed
  • Loading branch information
Anthony Spring committed Apr 1, 2020
1 parent d9af8cb commit 42d575f
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 3 deletions.
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ This project adheres to [Semantic Versioning](http://semver.org/).

- None at this time.

## [0.3.1] - 2020-04-01

Fixes:

- When generating a template the chart version was not properly provided for Helm3.

## [0.3.0] - 2020-02-04

Breaking Changes:
Expand Down Expand Up @@ -74,7 +80,8 @@ This example shows the `repo` has been omitted and the name pointing to a URL us

- Initial release

[Unreleased]: https://github.com/traackr/binnacle/compare/v0.3.0...HEAD
[Unreleased]: https://github.com/traackr/binnacle/compare/v0.3.1...HEAD
[0.3.1]: https://github.com/traackr/binnacle/tree/0.3.1
[0.3.0]: https://github.com/traackr/binnacle/tree/0.3.0
[0.2.1]: https://github.com/traackr/binnacle/tree/0.2.1
[0.2.0]: https://github.com/traackr/binnacle/tree/0.2.0
Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.3.0
0.3.1
7 changes: 6 additions & 1 deletion cmd/template.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func templateCmdRun(args ...string) {
if err != nil {
log.Fatalf("unable to load configuration: %v", err)
}

var charts = c.Charts

log.Debugf("Loaded %d charts.", len(charts))
Expand Down Expand Up @@ -154,6 +154,11 @@ func templateCmdRun(args ...string) {

cmdArgs = append(cmdArgs, "--values")
cmdArgs = append(cmdArgs, valuesFile)

if len(chart.Version) > 0 {
cmdArgs = append(cmdArgs, "--version")
cmdArgs = append(cmdArgs, chart.Version)
}
}

cmdArgs = append(cmdArgs, args...)
Expand Down

0 comments on commit 42d575f

Please sign in to comment.