Skip to content

Commit

Permalink
Remove --force from the helm3 command due to helm/helm#7350
Browse files Browse the repository at this point in the history
  • Loading branch information
aspring committed Jan 14, 2020
1 parent 291030c commit 2e0505e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ This project adheres to [Semantic Versioning](http://semver.org/).

- None at this time.

## [0.2.1] - 2020-01-13

- Remove the explicit '--force' from the command passed to helm3 upgrade during a `binnacle sync`.

## [0.2.0] - 2020-01-13

- This release introduces Helm 3 support by adding a lightweight touchpoint to detect if helm2 or helm3 is getting targetted and treating helm2 as the exception case for processing. This will allow helm2 support to be easily removed upon its EOL. To facilitate this detected binnacle will run `helm version` during certain commands to help determine the target version and change the underlying helm commands accordingly.
Expand Down
5 changes: 4 additions & 1 deletion cmd/sync.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,10 @@ func syncCharts(charts []config.ChartConfig, args ...string) error {
cmdArgs = append(cmdArgs, chart.Release)
cmdArgs = append(cmdArgs, chart.ChartShortName())
cmdArgs = append(cmdArgs, "-i")
cmdArgs = append(cmdArgs, "--force")

if IsHelm2() {
cmdArgs = append(cmdArgs, "--force")
}

if len(chart.Namespace) > 0 {
cmdArgs = append(cmdArgs, "--namespace")
Expand Down

0 comments on commit 2e0505e

Please sign in to comment.