Skip to content

Commit

Permalink
refactor: remove vendored write_file.bzl
Browse files Browse the repository at this point in the history
We didn't have local modifications so we can just depend directly on upstream
  • Loading branch information
alexeagle authored and gregmagolan committed Jan 16, 2022
1 parent eaf70f2 commit ea4bca1
Show file tree
Hide file tree
Showing 8 changed files with 6 additions and 150 deletions.
2 changes: 1 addition & 1 deletion internal/generated_file_test/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
load("//packages/rollup:index.bzl", "rollup_bundle")
load("//third_party/github.com/bazelbuild/bazel-skylib:rules/write_file.bzl", "write_file")
load("@bazel_skylib//rules:write_file.bzl", "write_file")

package(default_visibility = ["//visibility:public"])

Expand Down
2 changes: 1 addition & 1 deletion internal/node/test/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ load("@npm//typescript:index.bzl", "tsc")
load("//:index.bzl", "js_library")
load("//packages/jasmine:index.bzl", "jasmine_node_test")
load("//third_party/github.com/bazelbuild/bazel-skylib:rules/copy_file.bzl", "copy_file")
load("//third_party/github.com/bazelbuild/bazel-skylib:rules/write_file.bzl", "write_file")
load("@bazel_skylib//rules:write_file.bzl", "write_file")

# You can have a nodejs_binary with no node_modules attribute
# and no fine grained deps
Expand Down
2 changes: 1 addition & 1 deletion internal/pkg_npm/test/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ load("@build_bazel_rules_nodejs//:index.bzl", "pkg_npm")
load("//packages/jasmine:index.bzl", "jasmine_node_test")
load("//packages/rollup:index.bzl", "rollup_bundle")
load("//packages/concatjs:index.bzl", "ts_library")
load("//third_party/github.com/bazelbuild/bazel-skylib:rules/write_file.bzl", "write_file")
load("@bazel_skylib//rules:write_file.bzl", "write_file")

write_file(
name = "produces_files",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
load("@build_bazel_rules_nodejs//:index.bzl", "generated_file_test")
load("@build_bazel_rules_nodejs//third_party/github.com/bazelbuild/bazel-skylib:rules/write_file.bzl", "write_file")
load("@bazel_skylib//rules:write_file.bzl", "write_file")
load("//packages/typescript:index.bzl", "ts_project")

write_file(
Expand Down
2 changes: 1 addition & 1 deletion packages/typescript/test/ts_project/rootdir/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@build_bazel_rules_nodejs//third_party/github.com/bazelbuild/bazel-skylib:rules/write_file.bzl", "write_file")
load("@bazel_skylib//rules:write_file.bzl", "write_file")
load("//packages/typescript:index.bzl", "ts_project")

write_file(
Expand Down

This file was deleted.

This file was deleted.

2 changes: 1 addition & 1 deletion tools/npm_packages/bazel_workspaces_consistent/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@build_bazel_rules_nodejs//third_party/github.com/bazelbuild/bazel-skylib:rules/write_file.bzl", "write_file")
load("@bazel_skylib//rules:write_file.bzl", "write_file")
load(":index.bzl", "some_rule")

# Just a dumb target to make sure we can use it from code that installs this npm package
Expand Down

0 comments on commit ea4bca1

Please sign in to comment.