Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for recent change in Spigot API changing the name of the max health attribute. #7653

Closed
wants to merge 2 commits into from

Conversation

LlmDl
Copy link
Member

@LlmDl LlmDl commented Oct 28, 2024

Description:


New Nodes/Commands/ConfigOptions:


Relevant Towny Issue ticket:


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

@LlmDl LlmDl added this to the 0.101.0.0 milestone Oct 28, 2024
@LlmDl
Copy link
Member Author

LlmDl commented Oct 28, 2024

Compile is only failing because it probably used a cached version of spigot-api. The breaking change is only 2 hours old.

Copy link
Member

@Warriorrrr Warriorrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better solution to this would be to use Registry.ATTRIBUTE.get(NamespacedKey.minecraft("max_health"))

@LlmDl LlmDl closed this Nov 4, 2024
@LlmDl LlmDl deleted the fix/get_max_health_attribute branch November 4, 2024 15:31
@LlmDl LlmDl removed this from the 0.101.0.0 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants