Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WorldCoord#unloadChunks adding plugin chunk tickets #7478

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

galacticwarrior9
Copy link
Contributor

Description:

This PR fixes WorldCoord#unloadChunks adding plugin chunk tickets instead of removing them, which was causing chunks loaded by TownyRegenAPI to stay loaded indefinitely.

I closed the previous PR as it contained unrelated commits.


New Nodes/Commands/ConfigOptions:


Relevant Towny Issue ticket:


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

@LlmDl
Copy link
Member

LlmDl commented Jun 19, 2024

Ha, nice find, that is a bit serious...

@LlmDl LlmDl merged commit cb89cbb into TownyAdvanced:master Jun 19, 2024
1 check passed
@LlmDl LlmDl added this to the 0.100.4.0 milestone Jun 19, 2024
LlmDl added a commit that referenced this pull request Jun 19, 2024
galacticwarrior9 with PR #7478.
  - Handle empty towns during duplicate resident removal, courtesy of
Warrior with PR #7474.
  - Add plot group creation/deletion events #7476, courtesy of Warrior
with PR.
    - Closes #7475.
  - Bump org.apache.maven.plugins:maven-surefire-plugin from 3.2.5 to
3.3.0.
  - Drop support for MC 1.16-1.18, update the readme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants