Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dragon egg teleportation on left click #7419

Merged
merged 2 commits into from
May 16, 2024

Conversation

gecko10000
Copy link
Contributor

Description:

Dragon eggs currently teleport when an untrusted player left clicks on them (though right click is properly protected). This adds a check for dragon egg left clicks under switching protection to prevent players from teleporting the eggs.


New Nodes/Commands/ConfigOptions:

N/A


Relevant Towny Issue ticket:

N/A


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

Copy link
Member

@Warriorrrr Warriorrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code above (see line 470) uses a destroy test for right clicking dragon eggs, left clicking should be the same

@LlmDl LlmDl merged commit 9ed3880 into TownyAdvanced:master May 16, 2024
1 check passed
@LlmDl LlmDl added this to the 0.100.3.0 milestone May 16, 2024
LlmDl added a commit that referenced this pull request May 16, 2024
courtesy of Warrior with PRs #7412 & #7415.
    - Closes #7410.
  - Fix dragon egg teleportation on left click, courtesy of gecko10000
with PR #7419.
  - Fix TownyMessaging sending null messages.
  - Bump net.coreprotect:coreprotect from 22.3 to 22.4.
  - Bump com.github.seeseemelk:MockBukkit-v1.20 from 3.86.0 to 3.86.1.
  - Bump net.kyori:adventure-text-minimessage from 4.16.0 to 4.17.0.
  - Bump net.kyori:adventure-text-serializer-plain from 4.16.0 to
4.17.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants