Add sanctioned towns hover component to nation status screen #7207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LlmDl
requested changes
Jan 25, 2024
Towny/src/main/java/com/palmergames/bukkit/towny/TownyFormatter.java
Outdated
Show resolved
Hide resolved
|
should be all good now i think, i added the nation name to the clickevent |
LlmDl
requested changes
Jan 25, 2024
| @@ -507,6 +507,18 @@ public static StatusScreen getStatus(Nation nation, CommandSender sender) { | |||
| .append(Component.newline()) | |||
| .append(translator.component("status_hover_click_for_more"))), | |||
| ClickEvent.runCommand("/towny:nation enemylist " + nation.getName())); | |||
|
|
|||
| // Sanctioned Towns [3]: Prague, Berlin, Vienna | |||
There was a problem hiding this comment.
This comment should look like so: // [Sanctioned Towns] + hover (Yes I know most of the other comments are incorrect.)
LlmDl
approved these changes
Jan 27, 2024
LlmDl
added a commit
that referenced
this pull request
Jan 27, 2024
courtesy of Fruitloopins with PR #7207.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds a "[Sanctioned Towns]" section to the end of the nation status screen, it acts just like the enemies, allies, towns etc. hover components, clicking runs the list command (pictured below)
New Nodes/Commands/ConfigOptions:
N/A
Relevant Towny Issue ticket:
N/A
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.