Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google big query :: add scope parameter #61

Merged
merged 7 commits into from
Dec 20, 2018
Merged

google big query :: add scope parameter #61

merged 7 commits into from
Dec 20, 2018

Conversation

vdestraitt
Copy link
Contributor

@vdestraitt vdestraitt commented Dec 19, 2018 •
edited by piotch
Loading

Add scopes support #60

@piotch piotch changed the title Add scope parameter to big query connector google big query :: add scope parameter Dec 19, 2018
@piotch piotch mentioned this pull request Dec 19, 2018
Closed
@codecov-io
Copy link

codecov-io commented Dec 20, 2018 •
edited
Loading

Codecov Report

Merging #61 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   97.96%   97.97%   +0.01%     
==========================================
  Files          26       26              
  Lines         983      988       +5     
==========================================
+ Hits          963      968       +5     
  Misses         20       20
Impacted Files Coverage Δ
...ors/google_big_query/google_big_query_connector.py 100% <100%> (ø) ⬆️
toucan_connectors/common.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fff298...a65676f. Read the comment docs.

@PrettyWood PrettyWood added the enhancement New feature or request label Dec 20, 2018
@PrettyWood PrettyWood merged commit 206c7c0 into master Dec 20, 2018
@PrettyWood PrettyWood deleted the add-scope-bigquery branch December 20, 2018 10:09
raphaelvignes pushed a commit that referenced this pull request Jan 12, 2022
@vdestraitt @adimascio
Feature :: 'replace' step translation in mongo (#74)
5ee93da 
Translation of a `replace` step in Mongo aggregation pipeline steps.
The `replace` step aims to replace value in a column, and write the resulting column inplace or in a new column.

Closes [issue #61](ToucanToco/weaverbird#61)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrettyWood PrettyWood PrettyWood approved these changes

Assignees

@vdestraitt vdestraitt

Labels
enhancement New feature or request Need Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vdestraitt @codecov-io @PrettyWood @piotch