catch exceptions when trying to read access-restricted css files, and…

… update test case to look for css styling
TortoiseHam · Jan 12, 2024 · 9555c0c · 9555c0c
1 parent 635e5ee
commit 9555c0c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/src/traces/sankey/plot.js b/src/traces/sankey/plot.js
@@ -68,14 +68,18 @@ function linkHoveredStyle(d, sankey, visitNodes, sankeyLink) {
         // Figure out whether the user has provided their own sankey-link-hover style.
         var styleExists = false;
         for(var i = 0; i < document.styleSheets.length; i++) {
-            var rules = document.styleSheets[i].cssRules;
-            for(var j = 0; j < rules.length; j++) {
-                if(rules[j].selectorText === '.sankey-link-hover') {
-                    styleExists = true;
-                    break;
+            try {
+                var rules = document.styleSheets[i].cssRules;
+                for(var j = 0; j < rules.length; j++) {
+                    if(rules[j].selectorText === '.sankey-link-hover') {
+                        styleExists = true;
+                        break;
+                    }
                 }
+                if(styleExists) break;
+            } catch(e) {
+                // This particular style sheet cannot be accessed (due to CORS policy)
             }
-            if(styleExists) break;
         }
 
         // If not, insert a default one

diff --git a/test/jasmine/tests/sankey_test.js b/test/jasmine/tests/sankey_test.js
@@ -1087,7 +1087,7 @@ describe('sankey tests', function() {
                         .filter(function(obj) {
                             return obj.link.label === 'stream 1';
                         })[0].forEach(function(l) {
-                            expect(l.style.fillOpacity).toEqual('0.4');
+                            expect(l.classList.contains('sankey-link-hover')).toBe(true);
                         });
                 }).then(function() {
                     mouseEvent('mouseout', 200, 250);
@@ -1096,7 +1096,7 @@ describe('sankey tests', function() {
                         .filter(function(obj) {
                             return obj.link.label === 'stream 1';
                         })[0].forEach(function(l) {
-                            expect(l.style.fillOpacity).toEqual('0.2');
+                            expect(l.classList.contains('sankey-link-hover')).toBe(false);
                         });
                 })
                 .then(done, done.fail);