Cleanup

Topheee · Oct 3, 2023 · 4ce13d2 · 4ce13d2
1 parent 9200f84
commit 4ce13d2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/MatrixSDK/Crypto/CryptoMachine/MXCryptoMachine.swift b/MatrixSDK/Crypto/CryptoMachine/MXCryptoMachine.swift
@@ -615,10 +615,10 @@ extension MXCryptoMachine: MXCryptoCrossSigning {
     }
 
     func queryMissingSecretsFromOtherSessions() async throws {
-        let has_missing = try machine.queryMissingSecretsFromOtherSessions()
+        let isMissingSecrets = try machine.queryMissingSecretsFromOtherSessions()
 
-        if (has_missing) {
-            // Out-of-sync check if there are any secret request to sent out as a result of
+        if (isMissingSecrets) {
+            // Out-of-sync check if there are any secret request to send out as a result of
             // the missing secret request
             for request in try machine.outgoingRequests() {
                 if case .toDevice(_, let eventType, _) = request {

diff --git a/MatrixSDK/Crypto/MXCryptoV2.swift b/MatrixSDK/Crypto/MXCryptoV2.swift
@@ -391,11 +391,9 @@ class MXCryptoV2: NSObject, MXCrypto {
 
             if (userId == machine.userId) {
                 if (machine.crossSigningStatus().hasSelfSigning) {
-                    // if we can cross sign, upload a new signature for that device
+                    // If we can cross sign, upload a new signature for that device
                     Task {
                         do {
-                            // This method will always fail if the device belongs to someone else.
-                            // XXX Should update API? and remove the userId?
                             try await machine.verifyDevice(userId: userId, deviceId: deviceId)
                             log.debug("Successfully marked device as verified")
                             await MainActor.run {
@@ -430,7 +428,6 @@ class MXCryptoV2: NSObject, MXCrypto {
             do {
                 try machine.setLocalTrust(userId: userId, deviceId: deviceId, trust: localTrust)
                 log.debug("Successfully set local trust to \(localTrust)")
-                // XXX: Why no MainActor.run here?
                 success?()
             } catch {
                 log.error("Failed setting local trust", context: error)