Improve byte[]
serialising (plus formatting, protobuf and finished API documenting)
#21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not going to lie, a little work ended up spiralling, leaving most files updated (mostly from formatting)
Breaking Changes (Overview)
byte[]
and stream serialisation has changed, but is now significantly more robust (and simpler in its' implementation)byte[]
form. Before upgrading convert them to JSON and then upgrade and revert them backTypeTracker.DefaultFilterStatementTypes
has also been removed, as it is no longer required for serialisationChanges (Overview)
using
statementsPackage: TopMarksDevelopment.ExpressionBuilder.Api
Breaking Changes
IFilterCollection
/IFilterCollection<T?>
now expects anAddRange
methodAdded
(Chore: do the same to all other packages)
Package: TopMarksDevelopment.ExpressionBuilder.Core
Breaking Changes
byte[]
and stream serialisation has changed, but is now significantly more robustbyte[]
form. Before upgrading convert them to JSON and then upgrade and revert them backTypeTracker.DefaultFilterStatementTypes
has also been removed, as it is no longer required for serialisationAdded
.proto
file available hereFilterCollection
andFilterCollection<T?>
include anAddRange
method - supporting API ChangesIProtoFilterItem
interfaceUsed on classes that build our filter (implementing the conversion between types)
IProtoConverter
interfaceWhen your generic type is not a supported value, implementing this interface means we can still process it in
byte[]
serialisationProtoFilterStatement
classThe new class used for
byte[]
serialisation. This class does not have a generic type, so makes serialising a lot more simple and robustChanges
TypeTracker.DefaultFilterStatementTypes
work