Allow getting data by subclasses #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rf20008
approved these changes
Dec 1, 2021
You're not wrong, I kinda had a use case but I don't think it's practical (that's why this is still a draft). Though don't worry about the breaking change, we're indeed doing breaking changes. We've bumped the major version and it's still alpha anyway. |
|
@norinorin Do you plan on advancing further with this PR by any chance? |
|
Sorry I missed your comment. It's been a few years, and I don't remember the specifics of this PR (had to be related to one of my local projects). I must've left it in a usable state but forgot to remove the draft status. Feel free to merge it or close it as you see fit, if there is even an active maintainer that is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Allow getting data by subclasses. The time complexity is supposedly O(n) on the first lookup and O(1) afterwards as the first result got cached.