Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bean dialog - References usage #292

Closed
nirlib opened this issue Apr 27, 2017 · 3 comments
Closed

Bean dialog - References usage #292

nirlib opened this issue Apr 27, 2017 · 3 comments

Comments

@nirlib
Copy link

nirlib commented Apr 27, 2017

When references to file paths being used in bean dialog the input is saved without backslashes.
example : ${run:view} = F:\views\r - in bean dialog the value is F:viewsr

@itaiag itaiag changed the title Bean dialog - refernces usage Bean dialog - References usage Jun 12, 2017
@itaiag itaiag added the bug label Jun 21, 2017
@itaiag itaiag self-assigned this Jun 21, 2017
Ben-Mark added a commit that referenced this issue Jul 19, 2017
issue #292 fixed, added unit tests as well

merge commit : deleted redundant git "master" printings
itaiag pushed a commit that referenced this issue Jul 20, 2017
run parameter now accepts a backslash value , parameter provider unit test added demonstrating this additional fix with bean usage convention. issue #292
@itaiag itaiag added this to the 6.1.06 milestone Sep 4, 2017
@itaiag itaiag closed this as completed Sep 4, 2017
@itaiag
Copy link
Contributor

itaiag commented Oct 10, 2017

The fix causes a regression. Strings that include backslash that are part of parameter provider (Generic or array), get an additional three backslashes every time the bean dialog is closed by the user.

Steps to Reproduce

Open building block with parameter provided that has a string field. Fill backslash in the input.

before

Click on the OK button and open again.

after

@itaiag itaiag reopened this Oct 10, 2017
@itaiag
Copy link
Contributor

itaiag commented Oct 10, 2017

The fault is probably in the added code block in the ObjectArrayParameterProvider and in the GenericObjectParameterProvider:

		StringBuilder propertiesSb = new StringBuilder();
		for (String line : propertiesString.split("\\r?\\n")) {
			if (line.contains("\\") && !line.contains("\\:"))
				line = line.replace("\\", "\\\\");
			propertiesSb.append(line+"\r\n");
		}

@itaiag itaiag modified the milestones: 6.1.06, 6.1.07 Oct 10, 2017
itaiag pushed a commit that referenced this issue Nov 2, 2017
Fix for the issue #292
itaiag added a commit that referenced this issue Nov 23, 2017
@itaiag itaiag closed this as completed Nov 23, 2017
@itaiag itaiag reopened this Nov 28, 2017
itaiag added a commit that referenced this issue Dec 4, 2017
@itaiag itaiag modified the milestones: 6.1.07, 6.1.08 Dec 4, 2017
@itaiag itaiag closed this as completed Dec 4, 2017
@itaiag
Copy link
Contributor

itaiag commented Dec 13, 2017

Backslashes are also added to spaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants