Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run format check in CI #355

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Run format check in CI #355

merged 1 commit into from
Dec 6, 2024

Conversation

lukekarrys
Copy link
Collaborator

@lukekarrys lukekarrys commented Dec 6, 2024

This PR adds a format:check script to the root an runs it as part of the lint CI job.

A few other related changes:

  • The prettier scripts in package.json now target all files and rely on .prettierignore to ignore file types that should not be formatted. This works a little better with some tooling like VSCode plugins.
  • Runs both lint and format:check regardless of if one fails or not
  • Runs prettier --write . with these changes to catch some unformatted source code that has snuck in

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
proxy-agents ✅ Ready (Inspect) Visit Preview Dec 6, 2024 8:42pm

Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: 54ea8b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukekarrys lukekarrys merged commit 5fd2546 into main Dec 6, 2024
14 checks passed
@lukekarrys lukekarrys deleted the lk/ci-format branch December 6, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant